Show the certificate subject in the certificate list - #4842
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
The overview list rendered certificate.issuerDn, so every certificate signed by the same intermediate or root CA looked identical and there was no way to tell servers apart without opening each one. Show subjectDn instead, and add the OPC UA ApplicationUri from subjectAlternativeNames underneath, which is the identifier an operator matches a server on. Also drops a leftover console.log of the parsed DNS names from ngOnInit, which sat in the lines being changed. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4841.
certificate-label.component.htmlrenderedcertificate.issuerDn, so every certificate signed by the same intermediate or root CA showed the same string and there was no way to tell two servers apart without opening each one.It now shows
subjectDn, and the OPC UA ApplicationUri underneath it, taken from theURIentry ofsubjectAlternativeNamesas you suggested, since that is what an operator actually matches a server on. The DNS badges below are untouched.subjectDnandsubjectAlternativeNamesare both already on theCertificatemodel (streampipes-model.ts:721-738), so nothing needed to change on the API side.One thing outside the strict scope:
ngOnInithad a leftoverconsole.log(this.dnsNames)sitting in the lines I was editing, so it is gone too. Happy to put it back if you would rather keep this to the reported change.On verification, so the claim is not larger than what I did: this is a template and component change and I have not run the UI. I checked the field names against the generated model and ran the repo's own prettier config (3.7.4,
ui/.prettierrc.json) over both files, which reports "All matched files use Prettier code style". I have not runng lintor built the frontend, so CI is the real check there.