SOLR-18256: Fix lucene QParser to support nested pure negative queries

[abumarjikar]

https://issues.apache.org/jira/browse/SOLR-18256

Description

This pull request addresses a long-standing limitation where nested pure negative (NOT) queries wrapped in parentheses or sub-expressions inside the lucene QParser evaluate incorrectly (resulting in 0 matching documents). By overriding getBooleanQuery in SolrQueryParser, we now safely apply QueryUtils.makeQueryable() on every boolean group built during the parsing cycle. This correctly transforms and executes both top-level and nested pure negative sub-expressions as expected.

Solution

Modified SolrQueryParser to override getBooleanQuery(List<BooleanClause> clauses). Instead of relying purely on top-level query transformations to fix pure negative clauses, the parser now intercepts every boolean group built during syntax processing. If a generated BooleanQuery contains only prohibited (negative) clauses, QueryUtils.makeQueryable() automatically wraps or balances it against a MatchAllDocsQuery, restoring expected Lucene/Solr negation behavior seamlessly across nested parenthesized groups.

Tests

• Integrated a dedicated behavioral test case testNestedPureNegativeQuery inside solr/core/src/test/org/apache/solr/search/TestSolrQueryParser.java.
• Verified top-level and nested pure negative behavior under standard parenthesized groups using explicit AND (-field:val) and AND (NOT field:val) syntax variations against an isolated set of unique test documents.
• Ensured reliable query assertions by introducing an explicit sort parameter (id asc) to circumvent score weighting conflicts during JSON response validation.

Checklist

Please review the following and check all that apply:

• I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
• I have created a Jira issue and added the issue ID to my pull request title.
• I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
• I have developed this patch against the main branch.
• I have run ./gradlew check.
• I have added tests for my changes.
• I have added documentation for the Reference Guide
• I have added a changelog entry for my change

[dsmiley]

This should enable broad improvements across tests where a silly *:* is present next to a negative clause. Maybe not that many tests to update but still. Perhaps even the ref guide has a reference. Please search for the pattern. I suggest waiting until after your #4512 to avoid merge conflicts.

[abumarjikar]

Changes done as per review

[squallsama]

This query still contains must clause. Could you please try assert with pure negative like {!bool must_not='{!term f=v_t v=bar}'} ?

[abumarjikar]

assertJQ(
        req("q", "NOT v_t:pureneg", "df", "v_t", "fq", "type_t:negativetest"),
        "/response/numFound==0");

This does check the similar i just restricted to my test documents. Please let me know if i still need to add another test.

[dsmiley]

Did you see Hoss's input in JIRA?

[dsmiley]

Your the first I've seen to put the 'type" first.
Pro-tip: don't generate this file yourself; have Gradle do it via ./gradlew writeChangelog.