refactor(rust/sedona-raster): add RasterError to replace ArrowError plumbing - #1144
Draft
james-willis wants to merge 1 commit into
Draft
refactor(rust/sedona-raster): add RasterError to replace ArrowError plumbing#1144james-willis wants to merge 1 commit into
james-willis wants to merge 1 commit into
Conversation
…lumbing
The raster crates leaned on arrow_schema::ArrowError as their error type,
forcing a map_err at every boundary. Introduce a dedicated RasterError
(mirroring sedona-geometry's SedonaGeometryError, plus an Arrow(#[from])
variant since raster code calls Arrow constantly) with From bridges into
DataFusionError and ArrowError and from DataFusionError, and a
RasterResultExt::context() helper. Migrate the sedona-raster library
modules to return RasterError and collapse the downstream map_err churn in
sedona-raster-{functions,gdal,zarr} to ?/.context(). The AsyncRasterLoader
trait stays on ArrowError to keep that cross-crate/cross-language boundary
stable; internal-assertion errors still route through sedona_internal_err!.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a dedicated
RasterErrorfor the raster crates (mirroringsedona-geometry'sSedonaGeometryError) so error plumbing is?/.context()-based instead of manualArrowErrormap_err.