[ISSUE #542] Fix connect runtime stats oom - #543
Open
VictoryAnn wants to merge 1 commit into
Open
Conversation
RockteMQ-AI
approved these changes
Jun 11, 2026
RockteMQ-AI
approved these changes
Aug 22, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
LGTM — clear copy-paste bug fix. The size check and removal were operating on sourceTaskTimesList instead of sinkTaskTimesList, causing the sink list to grow unboundedly and eventually OOM. Fix is correct.
Automated review by github-manager-bot
RockteMQ-AI
approved these changes
Sep 3, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
Correct bug fix for a copy-paste error causing OOM in ConnectStatsService.sampling().
Findings
- [Critical] The original code was checking
sourceTaskTimesList.size()and removing fromsourceTaskTimesListimmediately after adding tosinkTaskTimesList. This meantsinkTaskTimesListgrew unboundedly (OOM), whilesourceTaskTimesListwas incorrectly trimmed after every sampling cycle. - [Info] The fix correctly changes both the size check and the
removeFirst()call to operate onsinkTaskTimesList, matching the list that was just appended to on the line above.
Verdict
LGTM. Clean fix for a clear copy-paste bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
fix connect runtime stats bug.