feat: add extension info to AdminSendMessageRequest - #115
Merged
lizhimins merged 1 commit intoJul 30, 2026
Conversation
lizhimins
approved these changes
Jul 30, 2026
lizhimins
approved these changes
Jul 30, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
AdminSendMessageRequestcurrently has no request-scoped channel for carrying routing hints. FIFO admin sends need to select queues with the hash algorithm associated with the original producer protocol; using a different selector can route the same message group or sharding key to a different queue or broker.This metadata controls how the Admin RPC is handled and should not be mixed into stored message properties. See #114 for the design discussion.
Changes
map<string, string> ext_info = 7toAdminSendMessageRequest.protocol_typeas the initial key, withREMOTINGandGRPC_V2values.Compatibility
The change is wire-compatible in both rolling-upgrade directions. Old servers ignore field 7; new servers receive an empty map from old clients and can apply their default behavior.
Verification
admin.protoand its imports into a descriptor set withprotoc 3.21.1.git diff --check.Closes #114