RATIS-2611. Clear pending queue on all install-snapshot replies#1524
Closed
spacemonkd wants to merge 1 commit into
Closed
RATIS-2611. Clear pending queue on all install-snapshot replies#1524spacemonkd wants to merge 1 commit into
spacemonkd wants to merge 1 commit into
Conversation
Contributor
Author
|
@szetszwo could you take a look at this PR? P.S. The tests have been generated via Cursor and have been validated locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
RATIS-2611. Clear pending queue on all install-snapshot replies
When calling the onNext method, in the various result cases here some cases do not call
removePending().NOT_LEADER
CONF_MISMATCH
UNRECOGNIZED
SNAPSHOT_EXPIRED
these cases do not clear the pending queue and this may possibly fail on the Preconditions.assertSame() check.
pending.poll()removes the oldest enqueued request index. The handler assumes that for each reply we will have one addPending() and then one removePending() call in order.So if we take an example of chunk install with
SNAPSHOT_EXPIREDaddPending()calls -> pending queue [0, 1, 2]removePending()call -> pending.poll() returns 0, condition passedThis edge case is handled in the PR.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2611
How was this patch tested?
Unit tests