-
Notifications
You must be signed in to change notification settings - Fork 519
(feat) Implement metrics rest api #4115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
obelix74
wants to merge
10
commits into
apache:main
Choose a base branch
from
obelix74:implement_metrics_rest_api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2e4d449
feat(metrics): add Table Metrics Reports query REST API (PR1)
74306d1
refactor(metrics): move query API/spec into extensions and add no-op …
6359602
fix(metrics): validate metricType and fail fast on missing catalog (P…
327c0f0
refactor(metrics): collapse MetricsQuerySpi into one enveloped listRe…
3e913d1
refactor(metrics): move spec to top-level, switch to POST multi-table…
b68281e
fix(metrics): scope TABLE_READ_METRICS to Iceberg tables, drop TABLE_…
32d7bf7
fix(metrics): ship operator-consumable Ranger service def, close data…
975c01c
refactor(metrics): make MetricsQuerySpi.listReports return a typed se…
a26c845
Merge remote-tracking branch 'upstream/main' into metrics-pr1-query-api
5b55c34
fix(metrics): migrate to AuthorizationIntent API, revert unrelated di…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LIST_TABLE_METRICS now requests table-metrics-read, but Polaris pins Ranger 2.9.0 and neither its Polaris service definition nor Ranger master defines that access type. Ranger validates policy access types against the service definition, while this PR adds it only to embedded test fixtures and does not add it to the table resource’s accessTypeRestrictions. Operators therefore cannot grant the new permission through the shipped definition. Could we provide an operator-consumable service-definition update and test LIST_TABLE_METRICS against that exact artifact?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 32d7bf7351d (
fix(metrics): ship operator-consumable Ranger service def, close data-read/metrics-read gap):serviceDefintoextensions/auth/ranger/src/main/resources/polaris-ranger-servicedef.json, the artifact operators register with Ranger Admin (README updated with the registration steps).table-metrics-readto thetableresource'saccessTypeRestrictions, which was indeed missing.RangerServiceDefConsistencyTest, which fails the build if that shipped artifact ever drifts from theserviceDefinauthz_tests/dev_polaris.json— the same fixtureRangerPolarisAuthorizerTestexercises forLIST_TABLE_METRICSand the rest of the authz suite. So the operator-facing service definition and the tested one are now provably the same artifact.