Skip to content

fix(services/lakefs): follow the pagination cursor instead of stopping after one page #8088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erickguan merged 1 commit into from
Aug 15, 2026
Merged

fix(services/lakefs): follow the pagination cursor instead of stopping after one page #8088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/services/lakefs/src/core.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ impl LakefsCore {
}

if let Some(after) = after {
url.push_str(&format!("&after={after}"));
url.push_str(&format!("&after={}", percent_encode_path(&after)));
}

let mut req = Request::get(&url);
Expand Down
9 changes: 6 additions & 3 deletions core/services/lakefs/src/lister.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,12 @@ impl oio::PageList for LakefsLister {
&self.path,
self.delimiter,
&self.amount,
// start after should only be set for the first page.
// start_after applies to the first page; later pages resume from the
// cursor the previous response returned.
if ctx.token.is_empty() {
self.after.clone()
} else {
None
Some(ctx.token.clone())
},
)
.await?;
Expand All @@ -84,7 +85,9 @@ impl oio::PageList for LakefsLister {
let decoded_response: LakefsListResponse =
serde_json::from_reader(bytes.reader()).map_err(new_json_deserialize_error)?;

ctx.done = true;
let pagination = decoded_response.pagination;
ctx.done = !pagination.has_more;
ctx.token = pagination.next_offset;

for status in decoded_response.results {
let entry_type = match status.path_type.as_str() {
Expand Down
Loading