Let ZipException bubble up from JarAnalyzer constructor (#144) - #148
Open
elharo wants to merge 1 commit into
Open
Let ZipException bubble up from JarAnalyzer constructor (#144)#148elharo wants to merge 1 commit into
elharo wants to merge 1 commit into
Conversation
Remove the redundant catch block that re-wrapped the ZipException with a new message and misleading 'ioe' variable name. The constructor already declares 'throws IOException', so the original exception now propagates unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #144
Removed the redundant
catch (ZipException)block in theJarAnalyzerconstructor. It re-wrapped the exception with a new message and a misleadingly-namedioevariable, adding no information beyond the original exception.The constructor already declares
throws IOException(andZipExceptionis a subclass), so the original exception now propagates unchanged. Also removed the now-unusedjava.util.zip.ZipExceptionimport.The existing
invalidJarFiletest (which assertsZipExceptionis thrown for an invalid JAR) still passes.