Fix documentation issues in site docs - #826
Open
elharo wants to merge 6 commits into
Open
Conversation
- Fix broken link: mail-lists.html -> mailing-lists.html - Fix insecure link: http -> https for maven.apache.org - Fix factual error: 'a single goal' -> '2 goals', add shade:help - Fix awkward phrasing in introductory sentence - Add missing resource transformers to usage table - Fix grammar: 'replaces with original' -> 'replaces the original' - Fix missing word: 'ways choose' -> 'ways to choose' - Fix APT escaping for excludeDefaults element - Fix typo: org.codehaud -> org.codehaus - Fix typo: 'straight forward' -> 'straightforward' - Fix possessive: 'Mavens' -> 'Maven's' - Fix insecure link in resource-transformers - Fix unclear phrasing about class references - Fix redundant phrasing about appending content - Fix copy-paste error: Groovy NOTICE -> extension module descriptors - Fix subject-verb agreement: 'plugin provide' -> 'plugin provides' - Fix formatting: extract prose from code block in shader example - Fix: 'an other' -> 'another' - Fix: 'Dependency to' -> 'Dependency for' - Fix: 'in your job' -> 'in your build'
Corrected wording for clarity in the documentation regarding merging content of specific files.
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Updates the Maven Shade Plugin site documentation to fix broken/insecure links, correct factual/grammar issues, and improve clarity/formatting across multiple pages.
Changes:
- Fixed broken/insecure links and corrected factual/grammar issues (e.g., goals count, typos, missing words).
- Improved wording and formatting so examples/text render correctly in APT/FML (escaping, code blocks).
- Expanded documentation to include missing resource transformers.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/site/fml/faq.fml | Fixes schemaLocation URL and improves grammar/clarity in an FAQ answer. |
| src/site/apt/usage.apt.vm | Adds missing transformer entries and updates package grouping text. |
| src/site/apt/index.apt.vm | Fixes links, updates goals overview, improves phrasing, and switches to HTTPS. |
| src/site/apt/examples/use-shader-other-impl.apt.vm | Fixes title/grammar and ensures prose renders outside code blocks. |
| src/site/apt/examples/resource-transformers.apt.vm | Fixes typos/wording, removes a copy-paste artifact, and switches to HTTPS. |
| src/site/apt/examples/includes-excludes.apt.vm | Corrects APT escaping so XML renders properly. |
| src/site/apt/examples/class-relocation.apt.vm | Fixes org.codehaud typo to org.codehaus in example configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes multiple issues across the site documentation:
index.apt.vm
mail-lists.html→mailing-lists.html(the correct generated page name)http://→https://for maven.apache.org guide linkshade:helpgoal (listed in site.xml)usage.apt.vm
org.apache.maven.plugins.shade.resource.propertiesto the resource transformers tablefaq.fml
includes-excludes.apt.vm
\→\/so the<excludeDefaults>false</excludeDefaults>element renders correctlyclass-relocation.apt.vm
org.codehaud→org.codehaus(two occurrences in the example POM)resource-transformers.apt.vm
http://→https://for plugin-tools linkuse-shader-other-impl.apt.vm
+-----+code block so it renders as text, not code