Use maven4-build instead of hand-rolling the matrix - #576
Merged
Conversation
The shared workflow already has a switch for a Maven-4-only build. Setting ff-maven and maven-matrix by hand does the same thing but repeats the version twice, needs re-pinning in two places on every RC, and skips the jdk-8 exclude that maven4-build adds for you — harmless only because jdk-matrix is pinned to 17 and 21 here. Matches the other Maven 4 plugins: clean, install, deploy, compiler, source, archiver and filtering all use maven4-build. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared workflow already has a switch for a Maven-4-only build. Setting
ff-mavenandmaven-matrixby hand does the same thing, but repeats the version twice, needs re-pinning in two places on every RC, and skips the{jdk: 8}exclude thatmaven4-buildadds for you — harmless here only becausejdk-matrixis pinned to 17 and 21.Matches how the other Maven 4 plugins are configured — clean, install, deploy, compiler, source, archiver and filtering all use
maven4-build. No behaviour change intended. Context in apache/maven#12676.