Build against Maven 4.0.0-rc-6 - #574
Closed
slachiewicz wants to merge 2 commits into
Closed
Conversation
Move the Maven 4 version property to the current RC and pin the same version explicitly in the Verify workflow, so CI does not depend on the maven4-version default in maven-gh-actions-shared. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
rc-6 relocated org.apache.maven.api.plugin.testing to org.apache.maven.testing.plugin. The old names survive as deprecated shims, so this still compiled — but MojoExtension's annotation lookup only recognises the new annotation types. With the old ones the @InjectMojo attributes come back null, the @baseDir pom is never read, and the mojo is handed MojoExtension's built-in default model instead: JarMojoTest.jarTestEnvironment:48 expected: <foo> but was: <myGroupId> Pointing the imports at the new package restores it. Same relocation as apache/maven-compiler-plugin#1104. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
Author
|
Superseded by #573, which is already merged and makes exactly the same three changes — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
mavenVersionto the current RC and pins the same version explicitly in the Verify workflow, so CI no longer depends on themaven4-versiondefault in maven-gh-actions-shared.The version bump alone made
JarMojoTestfail:rc-6 relocated
org.apache.maven.api.plugin.testingtoorg.apache.maven.testing.plugin. The old names survive as deprecated shims, so the test still compiled — butMojoExtension's annotation lookup only recognises the new annotation types. With the old ones the@InjectMojoattributes come back null, the@Basedirpom is never read, and the mojo is handedMojoExtension's built-in default model. Pointing the imports at the new package restores it; no production code changes.Worth flagging generally: this is a silent behavioural break, not a compile error, so any plugin still importing the deprecated package will keep building and quietly stop reading its test poms. Same relocation as apache/maven-compiler-plugin#1104.
Part of apache/maven#12676. Verified green on a fork before opening.