Preserve exact dependency class names containing dollar signs - #296
Open
wilx wants to merge 2 commits into
Open
Conversation
wilx
marked this pull request as ready for review
August 2, 2026 13:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes apache/maven-dependency-plugin#1345
Summary
Preserve exact JVM binary class names when collecting dependency usages and dependency artifact contents.
The analyzer previously assumed that every
$in a binary class name denoted an inner class and discarded or folded that name into its presumed container. Kotlin can emit bytecode that references only a nested class, so the corresponding artifact was incorrectly reported as unused. The assumption was also invalid for legal top-level Java class names containing$.Artifact lookup already deduplicates usages by artifact, so retaining the exact binary name correctly handles both nested classes and top-level names without independently inferring the source-level compilation unit.
The change adds:
$;Verification
mvn -Prun-its verifywith JDK 17: 128 unit tests and all 21 invoker builds passed.Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.