feat: durable message lifecycle from admission to execution - #3721
feat: durable message lifecycle from admission to execution#3721Astro-Han wants to merge 18 commits into
Conversation
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Preserve live Client capability bindings, make cancellation retries idempotent, and keep admission-backed transcripts out of compatibility Run synthesis until their root contract owns them. Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
M4n5ter
left a comment
There was a problem hiding this comment.
English
I found two correctness issues on exact head 2ea21a68950502615f5e109ce914a7af94a97140: one makes durable follow-up reordering fail for every real permutation, and the other rejects otherwise valid 32–49 KiB messages as an internal failure. The exact-head hosted test check is green, but its queue test uses an in-memory lifecycle stub for reorder and does not exercise either storage boundary.
简体中文
我在 exact head 2ea21a68950502615f5e109ce914a7af94a97140 上确认了两个正确性问题:持久化 follow-up 队列的任何实际换序都会失败;另一个问题会把本来合法的 32–49 KiB 消息错误地变成内部错误。当前 head 的托管 test 检查是绿色,但队列测试对重排使用了内存 lifecycle stub,没有覆盖这两个真实存储边界。
| const current = rows.map((row) => row.message_id); | ||
| if ( | ||
| current.length !== unique.length || | ||
| current.some((messageId, index) => messageId !== unique[index]) |
There was a problem hiding this comment.
English
[P1] Compare identity membership here instead of requiring the requested order to equal the current order. The caller invokes this method only when the order changed, but this predicate rejects every such permutation before the updates run. With two accepted follow-ups persisted as message-1, message-2, calling reorderMessageAdmissions(session, [message-2, message-1]) deterministically throws SessionMetadataConflictError and leaves the old order intact. The coordinator test does not catch this because its lifecycle fake implements reorderMessageAdmissions as a no-op. Please validate equal cardinality plus the same identity set, then write the requested order in this transaction, and add a real SQLite reorder-and-restart test.
简体中文
[P1] 这里应校验 identity 集合,而不是要求请求顺序与当前顺序完全相同。调用方只会在顺序发生变化时进入这个方法,但当前条件会在更新执行前拒绝所有实际 permutation。把两个 accepted follow-up 按 message-1, message-2 持久化后,调用 reorderMessageAdmissions(session, [message-2, message-1]) 会稳定抛出 SessionMetadataConflictError,持久顺序仍保持不变。现有 coordinator 测试没有发现它,因为 lifecycle fake 把 reorderMessageAdmissions 实现成了 no-op。请改为校验数量相同且 identity 集合一致,再在同一事务中写入请求顺序,并增加真实 SQLite 的换序与重启测试。
| disposition, | ||
| admittedAt: Date.now(), | ||
| }; | ||
| await this.#lifecycle.commitMessageAdmission(messageAdmission); |
There was a problem hiding this comment.
English
[P2] Preflight the exact pending-admission envelope before this write. The earlier guards check the public queue projection (submitted content) and future root payload (prepared content) separately, while the storage record contains both and has its own 64 KiB cap. Using the real decoders on this head, a plain 32 KiB message passes both earlier guards but normalizePendingMessageAdmission throws Pending message admission exceeds size limit; the mismatch continues through 49 KiB and escapes this handler as internal_failure. Please either align the durable format/limit with the supported envelopes or return a declared capacity error before mutation, and cover the 31/32/49/50 KiB boundaries with the real lifecycle store.
简体中文
[P2] 在这里写入前需要预检完整的 pending-admission envelope。前面的守卫分别检查公共队列 projection(submitted content)和未来 root payload(prepared content),但存储记录同时保存两份内容,并另有 64 KiB 上限。在当前 head 上使用真实 decoder 验证时,普通 32 KiB 消息能通过前两个守卫,却会在 normalizePendingMessageAdmission 抛出 Pending message admission exceeds size limit;这个错配一直持续到 49 KiB,并最终被转换成 internal_failure。请让持久化格式/上限与已支持的 envelope 对齐,或在任何 mutation 前返回明确的容量错误,并使用真实 lifecycle store 覆盖 31/32/49/50 KiB 边界。
Astro-Han
left a comment
There was a problem hiding this comment.
I reviewed this head and found blocking issues that need to be addressed before merge.
[P1] Recovery can replay raw /skill text instead of the prepared skill invocation
Idle submit persists raw modelContent first (message-coordinator.ts:906-918) and only later expands the skill in the Host (root-turn-coordinator.ts:1028-1077). If the Host exits between those steps, recovery replays the persisted raw content without re-running skill preparation, producing a root that the normal path would have wrapped.
[P1] Rejected idle submit leaves a phantom user message in the transcript
The admission and user transcript are written together, but later start/admission can still fail (skill blocked, oversized, binding failure). The cancellation only flips lifecycle state, not the transcript — a failed send remains visible and retries create duplicates.
[P2] Message reorder with identical content is rejected as a conflict
The metadata store compares target order byte-for-byte, so any non-trivial reorder is treated as a conflict. Existing tests pass only because reorders in those fixtures are no-ops.
[P2] Admission envelope can exceed storage limits undetected
Submitted and prepared payloads are checked separately, but the combined admission envelope (64 KiB limit) is not pre-validated. Inputs in the 32–49 KiB range pass early gates yet fail at admission, surfacing as an internal failure.
CI on 2ea21a689505 is test: success. These issues are independent of CI and require fixes before approval. Heads verified at time of review.
Summary
This is the first end-to-end durable message lifecycle PR built from the latest
main, replacing Draft PR #3633. It does not cherry-pick or continue the #3633 patch series.The problem is simple: once
turn.message.submitaccepts a message, a Host crash must not make that message disappear, revive it into a queue, or execute it twice.The solution keeps one durable authority for the message admission and one lifecycle/settlement owner.
queued,leased, andin_flightare Host-memory projections rebuilt from durable facts.The four durable values are facts, not a persisted provider state machine:
Accepted: SQLite admission and the canonical transcript row committed atomically.HandedOff: a durable root admission/source proof, or an immutable steering event, proves that Root execution owns the message.Executed: a durable provider-request proof exists downstream of that handoff proof. Steering uses its event timestamp as the lower bound.Cancelled: a retract proof or terminal Stop proof closes the message without downstream execution.First-principles ownership
SqliteSessionMetadataStoreowns the durable message admission, transcript identity, ordering, edits, reorders, promotion, retract, lifecycle rows, and size boundaries.RootAdmissionOwnerowns the durable Root execution contract and source-message proof.HostMessageCoordinatorowns only the reconstructible queue projection and the shared proof classifier/settlement owner used by normal terminal cleanup and restart recovery.Crash-cut behavior
Acceptedmessage into Host memory; it is not executed.Executed; it does not replay the message.Accepted/HandedOfffacts converge toExecutedorCancelledfrom durable proofs.Scope
Included: atomic admission and transcript, edit/reorder/promotion/retract, successor handoff, proof-driven settlement, restart recovery, size boundaries, canonical transcript identity, durable capability derivation, and removal of the old RuntimeKernel queue authority.
Excluded: CLI/Desktop projection refactors and Side Conversation UI/hooks.
Verification
Only affected builds and tests were run; the full repository test suite was not run.
2ea21a689.npm --workspace @maka/runtime run buildpassed.npm --workspace @maka/storage run buildpassed; SQLite metadata suite: 51 passed.npm --workspace @maka/runtime-host run buildpassed; production SQLite + Runtime Host/UDS message, queue, and coordinator suites: 60 passed.npm run astryx:surface-inventorypassed locally.npm run format:checkpassed.32758898698passed for exact head2ea21a689.AI use
This PR was implemented with Codex assistance. The design, repository decisions, code changes, affected-test selection, review of Draft PR #3633 evidence, adversarial review, simplification audit, and final verification were directed and checked against the repository's durable authorities and production composition.