Skip to content

refactor(core): drop retired execute permission mode from capability audit #3603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 2 commits into from
Aug 23, 2026
Merged

refactor(core): drop retired execute permission mode from capability audit #3603

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec26f69
refactor(core): drop retired 'execute' permission mode from capabilit…
yunaremaia Aug 23, 2026
0b1d820
style: apply biome formatting to capability-audit (CI fix)
yunaremaia Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions packages/core/src/capability-audit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export type SourceAuthType = (typeof SOURCE_AUTH_TYPES)[number];
export const SOURCE_RECORD_STATUSES = ['ready', 'needs_auth', 'error', 'disabled'] as const;
export type SourceRecordStatus = (typeof SOURCE_RECORD_STATUSES)[number];

export const CAPABILITY_AUDIT_PERMISSION_MODES = ['explore', 'ask', 'execute'] as const;
export const CAPABILITY_AUDIT_PERMISSION_MODES = ['explore', 'ask'] as const;
export type CapabilityAuditPermissionMode = (typeof CAPABILITY_AUDIT_PERMISSION_MODES)[number];

export const SCHEDULED_TASK_LAST_RUN_STATUSES = ['ok', 'error', 'skipped'] as const;
Expand Down Expand Up @@ -64,7 +64,7 @@ export interface SkillAuditRecord {
declaredTools: string[];
enabled: boolean;
sourceSlug: string;
permissionMode: Exclude<CapabilityAuditPermissionMode, 'execute'>;
permissionMode: CapabilityAuditPermissionMode;
}

export interface ScheduledTaskAuditRecord {
Expand Down Expand Up @@ -201,8 +201,9 @@ function scheduledTaskToAuditRecord(task: ScheduledTask): ScheduledTaskAuditReco

function scheduledTaskPermissionMode(task: ScheduledTask): CapabilityAuditPermissionMode {
if (task.status === 'completed' || task.status === 'expired') return 'explore';
if (task.status === 'paused') return 'ask';
return 'execute';
// Active tasks run with `ask` approval — the retired `execute` mode folded to
// `ask` identically, so this preserves the historical behaviour.
return 'ask';
}

function mapScheduledTaskRunOutcome(outcome: ScheduledTaskRunOutcome): ScheduledTaskLastRunStatus {
Expand All @@ -228,8 +229,9 @@ function summarizeCapabilityAudit(
declaredToolKindCount: distinctDeclaredToolKinds(skills).length,
scheduledTaskCount: scheduledTasks.length,
enabledScheduledTaskCount: scheduledTasks.filter((task) => task.enabled).length,
executableScheduledTaskCount: scheduledTasks.filter((task) => task.permissionMode === 'execute')
.length,
executableScheduledTaskCount: scheduledTasks.filter(
(task) => task.enabled && task.permissionMode !== 'explore',
).length,
failedScheduledTaskCount: scheduledTasks.filter((task) => task.lastRunStatus === 'error')
.length,
skippedScheduledTaskCount: scheduledTasks.filter((task) => task.lastRunStatus === 'skipped')
Expand Down