Skip to content

test(mcp): stabilize refresh budget synchronization - #3598

Open
CuSO41108 wants to merge 1 commit into
apache:mainfrom
CuSO41108:codex/test-mcp-refresh-budget
Open

test(mcp): stabilize refresh budget synchronization#3598
CuSO41108 wants to merge 1 commit into
apache:mainfrom
CuSO41108:codex/test-mcp-refresh-budget

Conversation

@CuSO41108

Copy link
Copy Markdown
Contributor

Summary

Make the spaced list-changed refresh-budget E2E test wait for the manager's successful refresh publication instead of polling tools/list requests against a one-second wall-clock deadline. This keeps the production refresh behavior unchanged while retaining a bounded whole-test timeout for genuine non-convergence.

Fixes #3307

Verification

  • npm run lint — passed (2,623 files)
  • npm run format:check — passed (1,603 files)
  • npm --workspace @maka/mcp run typecheck — passed
  • npm --workspace @maka/mcp run test:dist — passed (171 tests)
  • Targeted refresh-budget test repetitions — passed (20/20 on the latest base; 50/50 before the final rebase)
  • npm run build — Core, Storage, and MCP passed; the full command stopped in unrelated @maka/runtime compilation because the shared local dependency tree lacks @slack/web-api / @slack/socket-mode and exposes a mismatched HttpsProxyAgent type
  • npm run typecheck — affected MCP workspace passed; the aggregate command reported the same unrelated local @maka/runtime dependency errors above

The pre-change failure is load-sensitive rather than deterministic on every local run; the linked issue records the failing CI run and a code-identical successful rerun.

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: OpenAI Codex assisted with diagnosis, the test synchronization change, verification, and PR preparation. The commit carries Generated-by: Codex; CuSO41108 is the human contributor of record.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

Copilot AI lite review requested due to automatic review settings August 23, 2026 10:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request stabilizes the MCP refresh-budget E2E test by synchronizing with successful manager refresh publication.

Changes:

  • Adds a bounded 30-second test timeout.
  • Replaces wall-clock polling with refresh-publication synchronization.
  • Retains request-count assertions without changing production behavior.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@CuSO41108

Copy link
Copy Markdown
Contributor Author

Hi @Astro-Han, could you please approve the pending GitHub Actions workflow run for this fork PR? The required test check is currently waiting for maintainer approval, so CI has not started yet. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(mcp): list-changed refresh budget test flakes under CI load

2 participants