test(mcp): stabilize refresh budget synchronization - #3598
Open
CuSO41108 wants to merge 1 commit into
Open
Conversation
Generated-by: Codex
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request stabilizes the MCP refresh-budget E2E test by synchronizing with successful manager refresh publication.
Changes:
- Adds a bounded 30-second test timeout.
- Replaces wall-clock polling with refresh-publication synchronization.
- Retains request-count assertions without changing production behavior.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
Hi @Astro-Han, could you please approve the pending GitHub Actions workflow run for this fork PR? The required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the spaced
list-changedrefresh-budget E2E test wait for the manager's successful refresh publication instead of pollingtools/listrequests against a one-second wall-clock deadline. This keeps the production refresh behavior unchanged while retaining a bounded whole-test timeout for genuine non-convergence.Fixes #3307
Verification
npm run lint— passed (2,623 files)npm run format:check— passed (1,603 files)npm --workspace @maka/mcp run typecheck— passednpm --workspace @maka/mcp run test:dist— passed (171 tests)npm run build— Core, Storage, and MCP passed; the full command stopped in unrelated@maka/runtimecompilation because the shared local dependency tree lacks@slack/web-api/@slack/socket-modeand exposes a mismatchedHttpsProxyAgenttypenpm run typecheck— affected MCP workspace passed; the aggregate command reported the same unrelated local@maka/runtimedependency errors aboveThe pre-change failure is load-sensitive rather than deterministic on every local run; the linked issue records the failing CI run and a code-identical successful rerun.
AI use
Select exactly one:
Tool(s) and scope: OpenAI Codex assisted with diagnosis, the test synchronization change, verification, and PR preparation. The commit carries
Generated-by: Codex; CuSO41108 is the human contributor of record.Checklist
Does this PR entail a change in behavior?