Skip to content

chore: add the ASF header to the renderer-loss recovery files - #3504

Merged
jackwener merged 1 commit into
mainfrom
chore/asf-headers-3495
Aug 22, 2026
Merged

chore: add the ASF header to the renderer-loss recovery files#3504
jackwener merged 1 commit into
mainfrom
chore/asf-headers-3495

Conversation

@Astro-Han

Copy link
Copy Markdown
Contributor

Summary

#3495 branched before #3397 landed, so its two new files arrived without the ASF header, and its CI run predates the audit job that #3397 added. check:asf-headers runs in ci.yml, so main is currently failing that check and every open PR inherits the failure until this lands.

npm run write:asf-headers produced this commit. Nothing else was touched.

Refs #3495, #3397

Verification

  • node scripts/asf-license-headers.mjs check on main before this change: 2 files missing (apps/desktop/src/main/main-renderer-process-gone.ts and its test).
  • Same command on this branch: clean.
  • No behavior to test: both files gain a leading license comment and nothing else.

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: Claude Code — ran the header writer and wrote this description. The commit carries a Generated-by: Claude Code trailer.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

#3495 branched before #3397 landed, so its two new files arrived without the
ASF header and its CI predates the `audit` job. `check:asf-headers` runs in
`ci.yml`, so main is currently failing that check and every open PR inherits
the failure.

`npm run write:asf-headers` produced this; nothing else was touched.

Generated-by: Claude Code

@jackwener jackwener left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two files from #3495 were missing the ASF header after the #3397 gate landed. This is exactly those headers, nothing else. Approve.

@jackwener
jackwener merged commit 4acfa26 into main Aug 22, 2026
1 check passed
@jackwener
jackwener deleted the chore/asf-headers-3495 branch August 22, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants