fix(runtime-host,ui,cli): name live tool calls on compact and collapsed rows

apps/desktop/src/main/__tests__/tool-args-redaction-contract.test.ts

@@ -20,6 +20,7 @@
 import { describe, it } from 'node:test';
 import assert from 'node:assert/strict';
 import { formatRedactedJson, formatToolIntent } from '@maka/ui';
+import { formatToolInvocationLine, projectToolArgsPreview } from '@maka/core/tool-quiet-preview';
 
 describe('tool args redaction', () => {
   it('redacts JSON-shaped args before they are rendered', () => {
@@ -44,4 +45,24 @@ describe('tool args redaction', () => {
     assert.ok(rendered.length <= 241);
 
   });
+
+  it('keeps secrets out of the collapsed-row invocation line and its wire preview', () => {
+    // Built at runtime so no literal secret ever sits in the repo.
+    const bearerToken = ['sk', 'live', 'test', '9f8e7d6c5b4a'].join('-');
+    const passwordValue = ['maka', 'pw', '1a2b3c4d'].join('-');
+    const args = {
+      command: `curl -H "Authorization: Bearer ${bearerToken}" https://example.test`,
+      password: passwordValue,
+    };
+    const line = formatToolInvocationLine({ toolName: 'Bash', args }, 'en');
+    assert.ok(line !== undefined);
+    assert.doesNotMatch(line, new RegExp(bearerToken));
+    assert.match(line, /redacted/i);
+
+    const preview = projectToolArgsPreview('Bash', args);
+    const serialized = JSON.stringify(preview ?? null);
+    assert.doesNotMatch(serialized, new RegExp(bearerToken));
+    assert.doesNotMatch(serialized, new RegExp(passwordValue));
+    assert.doesNotMatch(serialized, /password/);
+  });
 });

packages/cli/src/__tests__/pi-transcript.test.ts

@@ -3431,6 +3431,90 @@ describe('Maka Pi TUI transcript', () => {
     }
   });
 
+  test('names a live quiet Bash row from the wire args preview', () => {
+    const state = createMakaPiTranscriptState();
+    // Runtime Host live tool_start omits full args; the bounded preview is all
+    // the compact row has until the turn-end reconcile.
+    applyMakaSessionEventToTranscript(
+      state,
+      event({
+        type: 'tool_start',
+        toolUseId: 'bash-preview',
+        toolName: 'Bash',
+        args: undefined,
+        argsPreview: { command: 'git status --porcelain' },
+      }),
+    );
+    applyMakaSessionEventToTranscript(
+      state,
+      event({
+        type: 'tool_result',
+        toolUseId: 'bash-preview',
+        isError: false,
+        content: {
+          kind: 'terminal',
+          cwd: '/repo',
+          cmd: 'git status --porcelain',
+          status: 'completed',
+          exitCode: 0,
+          output: { mode: 'pipes', stdout: '', stderr: '' },
+        },
+      }),
+    );
+
+    const rendered = renderMakaPiTranscript(state, meta(), 80).map(stripAnsi).join('\n');
+    assert.match(rendered, /\$ git status --porcelain/);
+    // Once the row names the call, the quiet-success disclaimer is noise.
+    assert.doesNotMatch(rendered, /\(no output\)/);
+  });
+
+  test('keeps the no-output placeholder when the row cannot name the call', () => {
+    const state = createMakaPiTranscriptState();
+    applyMakaSessionEventToTranscript(
+      state,
+      event({ type: 'tool_start', toolUseId: 'bash-blind', toolName: 'Bash', args: undefined }),
+    );
+    applyMakaSessionEventToTranscript(
+      state,
+      event({
+        type: 'tool_result',
+        toolUseId: 'bash-blind',
+        isError: false,
+        content: {
+          kind: 'terminal',
+          cwd: '/repo',
+          cmd: 'true',
+          status: 'completed',
+          exitCode: 0,
+          output: { mode: 'pipes', stdout: '', stderr: '' },
+        },
+      }),
+    );
+
+    const rendered = renderMakaPiTranscript(state, meta(), 80).map(stripAnsi).join('\n');
+    assert.match(rendered, /\(no output\)/);
+  });
+
+  test('names a task_create row by its first subject, not a JSON dump', () => {
+    const state = createMakaPiTranscriptState();
+    applyMakaSessionEventToTranscript(
+      state,
+      event({
+        type: 'tool_start',
+        toolUseId: 'task-1',
+        toolName: 'task_create',
+        displayName: 'Task Create',
+        args: undefined,
+        argsPreview: { tasks: [{ subject: '修复登录 bug' }], tasksTotal: 2 },
+      }),
+    );
+
+    const rendered = renderMakaPiTranscript(state, meta(), 80).map(stripAnsi).join('\n');
+    assert.match(rendered, /修复登录 bug/);
+    assert.doesNotMatch(rendered, /tasks:/);
+    assert.doesNotMatch(rendered, /\(no output\)/);
+  });
+
   test('orders and de-dupes tool_output_delta by seq and marks redacted chunks', () => {
     const state = createMakaPiTranscriptState();
     applyMakaSessionEventToTranscript(

packages/cli/src/pi-transcript-tools.ts

@@ -93,14 +93,19 @@ function toolDurationText(entry: MakaPiToolEntry): string {
  * expand, so the row needs neither
  * a separator glyph nor an expand marker. Short annotations are reserved
  * whole during truncation: a long command can never hide an `exit 1`.
+ *
+ * The `no output` placeholder appears only when the row cannot name the call
+ * (no input summary): once the target says what ran, `● Bash  $ git add -A`
+ * reads complete on its own and the disclaimer is noise.
  */
 function renderCompactToolBlock(entry: MakaPiToolEntry, width: number): string[] {
   const inputSummary = collapseToSingleLine(toolInputSummary(entry));
   const head = `${toolDisc(entry)} ${entry.title ?? entry.toolName}`;
   const annotation = compactAnnotation(entry);
+  const annotationText = annotation.placeholderOnly && inputSummary ? '' : annotation.text;
   return [
     fitLine(
-      assembleCompactToolRow(head, inputSummary, annotation.text, width, annotation.protect),
+      assembleCompactToolRow(head, inputSummary, annotationText, width, annotation.protect),
       width,
     ),
   ];
@@ -114,19 +119,26 @@ function renderCompactToolBlock(entry: MakaPiToolEntry, width: number): string[]
  * `protect` reports whether every part is a fixed shape (durations always
  * are): only protected annotations are reserved whole during truncation.
  */
-function compactAnnotation(entry: MakaPiToolEntry): { text: string; protect: boolean } {
+function compactAnnotation(entry: MakaPiToolEntry): {
+  text: string;
+  protect: boolean;
+  /** True when the annotation is solely the dim `no output` placeholder. */
+  placeholderOnly: boolean;
+} {
   const parts: string[] = [];
   const duration = toolDurationText(entry);
   if (duration) parts.push(duration);
   let protect = true;
+  let placeholderOnly = false;
   if (makaPiToolPresentationStatus(entry) !== 'running') {
     const summary = compactToolSummary(entry);
     if (summary && !(summary.placeholder && parts.length > 0)) {
       parts.push(collapseToSingleLine(summary.text));
       protect = summary.protect === true;
+      placeholderOnly = summary.placeholder === true && parts.length === 1;
     }
   }
-  return { text: parts.length > 0 ? `(${parts.join(' · ')})` : '', protect };
+  return { text: parts.length > 0 ? `(${parts.join(' · ')})` : '', protect, placeholderOnly };
 }
 
 /**
@@ -823,7 +835,11 @@ function toolInputSummary(entry: MakaPiToolEntry): string {
   const line = formatToolInvocationLine({ toolName: entry.toolName, args: input }, 'en');
   if (line) return limitText(line, 600);
   // Absolute last resort — still single-line for the compact header contract.
-  return `input: ${limitText(formatUnknownInline(input), 600)}`;
+  // An empty args object carries no information; leave the row bare instead of
+  // printing `input: {}` noise (and let a quiet result keep its placeholder).
+  const inline = formatUnknownInline(input);
+  if (inline === '{}') return '';
+  return `input: ${limitText(inline, 600)}`;
 }
 
 /**

packages/cli/src/pi-transcript.ts

@@ -569,14 +569,16 @@ export function applyMakaSessionEventToTranscript(
       const suppressed =
         (event.toolName === 'Read' || event.toolName === 'StopBackgroundTask') &&
         !!ref &&
-        !!findShellRunParent(state, ref, event.toolUseId);
-      state.entries.push({
+        !!findShellRunParent(state, ref, event.toolUseId);      state.entries.push({
         kind: 'tool',
         turnId: event.turnId,
         toolUseId: event.toolUseId,
         toolName: event.toolName,
         ...(event.displayName ? { title: event.displayName } : {}),
-        input: projectToolActivityArgs(event.toolName, event.args),
+        // Live Runtime Host frames omit full args; the bounded wire preview
+        // still lets the compact row name the call. The turn-end reconcile
+        // replaces it with the durable full args.
+        input: projectToolActivityArgs(event.toolName, event.args ?? event.argsPreview),
         resultVersion: 0,
         progress: createProgressBuffer(),
         outputDeltas: createOutputBuffer(),

packages/core/src/__tests__/tool-quiet-preview.test.ts

@@ -19,7 +19,13 @@
 
 import { strict as assert } from 'node:assert';
 import { describe, it } from 'node:test';
-import { formatAsKeyValueLines, formatQuietJsonValue } from '../tool-quiet-preview.js';
+import {
+  formatAsKeyValueLines,
+  formatQuietJsonValue,
+  formatToolInvocationLine,
+  projectToolArgsPreview,
+} from '../tool-quiet-preview.js';
+import { projectToolActivityArgs } from '../tool-activity-args.js';
 
 describe('tool quiet preview', () => {
   it('redacts secrets in values and embedded keys', () => {
@@ -31,3 +37,153 @@ describe('tool quiet preview', () => {
     assert.match(key, /redacted/i);
   });
 });
+
+describe('formatToolInvocationLine', () => {
+  it('names a Bash call by its command', () => {
+    const line = formatToolInvocationLine(
+      { toolName: 'Bash', args: { command: 'git status --porcelain' } },
+      'en',
+    );
+    assert.equal(line, 'git status --porcelain');
+  });
+
+  it('names a task_create call by its first subject with a count suffix', () => {
+    const line = formatToolInvocationLine(
+      {
+        toolName: 'task_create',
+        args: { tasks: [{ subject: '修复登录 bug' }, { subject: '写测试' }] },
+      },
+      'zh',
+    );
+    assert.equal(line, '修复登录 bug 等 2 项');
+    const en = formatToolInvocationLine(
+      {
+        toolName: 'task_create',
+        args: { tasks: [{ subject: 'Fix login' }, { subject: 'Add tests' }, { subject: 'Ship' }] },
+      },
+      'en',
+    );
+    assert.equal(en, 'Fix login +2 more');
+  });
+
+  it('names a task_update call by subject, then id and status', () => {
+    assert.equal(
+      formatToolInvocationLine(
+        { toolName: 'task_update', args: { id: 'T1', subject: '改名后的任务' } },
+        'zh',
+      ),
+      '改名后的任务',
+    );
+    assert.equal(
+      formatToolInvocationLine(
+        { toolName: 'task_update', args: { id: 'T1', status: 'completed' } },
+        'en',
+      ),
+      'T1 → completed',
+    );
+  });
+
+  it('names a GoalSet call by its condition', () => {
+    const line = formatToolInvocationLine(
+      { toolName: 'GoalSet', args: { condition: 'all tests in packages/runtime pass' } },
+      'en',
+    );
+    assert.equal(line, 'all tests in packages/runtime pass');
+  });
+
+  it('names an AskUserQuestion call by its first question with a count suffix', () => {
+    const line = formatToolInvocationLine(
+      {
+        toolName: 'AskUserQuestion',
+        args: {
+          questions: [
+            { question: '选哪个方案?', options: [{ label: 'A' }, { label: 'B' }] },
+            { question: '继续吗?', options: [{ label: '是' }, { label: '否' }] },
+          ],
+        },
+      },
+      'zh',
+    );
+    assert.equal(line, '选哪个方案? 等 2 问');
+  });
+
+  it('keeps the ScheduledTask title headline', () => {
+    const line = formatToolInvocationLine(
+      {
+        toolName: 'ScheduledTask',
+        args: { title: '每天 9:00 生成日报', schedule: { kind: 'cron' } },
+      },
+      'zh',
+    );
+    assert.equal(line, '每天 9:00 生成日报');
+  });
+});
+
+describe('projectToolArgsPreview', () => {
+  it('keeps only the formatter-readable fields, shaped like the args', () => {
+    const preview = projectToolArgsPreview('Write', {
+      path: 'packages/ui/src/tool-activity.tsx',
+      content: 'a very large file body that must never reach the wire',
+    });
+    assert.deepEqual(preview, { path: 'packages/ui/src/tool-activity.tsx' });
+  });
+
+  it('redacts secrets embedded in command strings', () => {
+    const preview = projectToolArgsPreview('Bash', {
+      command: 'curl -H "Authorization: Bearer super-secret-token-value" https://example.com',
+    });
+    const serialized = JSON.stringify(preview);
+    assert.doesNotMatch(serialized, /super-secret-token-value/);
+    assert.match(serialized, /redacted/i);
+  });
+
+  it('drops sensitive keys entirely', () => {
+    const preview = projectToolArgsPreview('SomeTool', {
+      title: 'hello',
+      password: 'hunter2',
+      api_key: 'abcdef',
+    });
+    assert.deepEqual(preview, { title: 'hello' });
+  });
+
+  it('bounds long values and whole-preview size', () => {
+    const preview = projectToolArgsPreview('Bash', { command: 'x'.repeat(5000) });
+    const command = (preview as { command: string }).command;
+    assert.ok(command.length <= 240, `expected <=240 chars, got ${command.length}`);
+    assert.ok(command.endsWith('…'));
+    assert.ok(JSON.stringify(preview).length <= 2048);
+  });
+
+  it('keeps task subjects so the formatter reports the original count', () => {
+    const preview = projectToolArgsPreview('task_create', {
+      tasks: [
+        { subject: 'one', parent_id: 'p' },
+        { subject: 'two' },
+        { subject: 'three' },
+        { subject: 'four' },
+        { subject: 'five' },
+      ],
+    });
+    const line = formatToolInvocationLine({ toolName: 'task_create', args: preview }, 'zh');
+    assert.equal(line, 'one 等 5 项');
+  });
+
+  it('preserves the WriteStdin projected inputPreview shape', () => {
+    const projected = projectToolActivityArgs('WriteStdin', {
+      ref: 'maka://runtime/background-tasks/1',
+      input: 'ls -la\n',
+      size: { cols: 80, rows: 24 },
+    });
+    const preview = projectToolArgsPreview('WriteStdin', projected);
+    const line = formatToolInvocationLine({ toolName: 'WriteStdin', args: preview }, 'zh');
+    assert.ok(line !== undefined);
+    assert.match(line, /后台终端交互/);
+    assert.match(line, /80x24/);
+  });
+
+  it('returns undefined when nothing displayable exists', () => {
+    assert.equal(projectToolArgsPreview('Bash', {}), undefined);
+    assert.equal(projectToolArgsPreview('Bash', undefined), undefined);
+    assert.equal(projectToolArgsPreview('Bash', { content: 'not a headline field' }), undefined);
+  });
+});

packages/core/src/events.ts

@@ -543,6 +543,12 @@ export interface ToolStartEvent extends BaseEvent, ToolActivityIdentity {
   providerExecuted?: boolean;
   displayName?: string;
   intent?: string;
+  /**
+   * Transient, never persisted: a bounded/redacted args subset synthesized at
+   * the Runtime Host client seam (live `tool_start` frames omit full args).
+   * Display formatters read `args ?? argsPreview`; durable replay never has it.
+   */
+  argsPreview?: unknown;
   /**
    * Id of the assistant step this tool call belongs to (equals the step's
    * AssistantMessage id / the step's text+thinking messageId). Lets model