Skip to content

feat(win): Abort-path installer rollback with backup retention #3265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 3 commits into from
Aug 23, 2026
Merged

feat(win): Abort-path installer rollback with backup retention #3265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1c1579
feat(win): Abort-path installer rollback with backup retention
liugddx Aug 20, 2026
1b6b6af
test(rollback): pin the hookless Quit exit code at its measured value
liugddx Aug 20, 2026
8f003ad
fix(test): scope rollback registry cleanup to fixture
liugddx Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/release-windows-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,10 @@ on:
- 'scripts/verify-windows-sandbox-e2e.mjs'
- 'scripts/verify-windows-installer-lifecycle.mjs'
- 'scripts/verify-windows-autoupdate.mjs'
- 'scripts/verify-windows-installer-rollback.mjs'
- 'scripts/package-windows-autoupdate-next.mjs'
# The Abort-path rollback hook ships inside the installer itself.
- 'apps/desktop/build/installer.nsh'
# The packaged updater's feed behavior — and the boot wiring that hands
# MAKA_UPDATE_TEST_FEED to it — is only observable on this path.
- 'apps/desktop/src/main/app-update-service.ts'
Expand Down Expand Up @@ -70,7 +73,7 @@ concurrency:
jobs:
package:
runs-on: windows-2025
timeout-minutes: 75
timeout-minutes: 90
defaults:
run:
shell: bash
Expand Down Expand Up @@ -122,3 +125,10 @@ jobs:
npm run verify:windows-autoupdate -- \
"apps/desktop/release/Maka-${version}-win-x64.exe" \
apps/desktop/release-autoupdate-next

- name: Prove deterministic mid-install failure rollback

@Astro-Han Astro-Han Aug 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Get this step green once and put the log in the PR body before the word "proven" ships. I queried check-runs for every commit on this branch — 90f1a275e, 3335af80b, 76de157af, db5450d7c, e84ab2c3a, 3fc75306d — and the package job is failure, failure, cancelled, failure, failure, failure, with the head's still in progress. Pulling the full logs for the four failed jobs and grepping for verify-windows-installer-rollback returns zero hits in every one: the step has never run. The most recent job died in the preceding verify:windows-autoupdate on a CDP attach that took about six minutes against a 90-second budget, which is the very bug the head commit is trying to fix. So the only execution evidence this PR currently has is that a normal 0.1.9→0.1.11 upgrade still passes the lifecycle gate with the hook installed — a happy-path non-regression, not a demonstration of rollback. Until the step reports, "proven" should not appear in the title, in docs/windows-support.md, or in the Chinese docs. When it does run, the body should carry the manifest file count, the exit code 102, the 0 differing files line and the control run. Reproduced by execution against the GitHub API and the job logs.

@liugddx liugddx Aug 21, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The transactional and proven claims have been removed from the title, installer/workflow/builder comments, verifier diagnostics, and EN/zh rollback documentation. Exact-head Windows evidence is intentionally still marked pending in the PR body. Fresh Release Windows check run 32477989412 is running now; I am leaving this verification thread open until its rollback step completes and the exact log evidence is posted.

@liugddx liugddx Aug 21, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fresh exact-head evidence is now green: Release Windows check 32477989412 passed in 23m21s on 68520adc.

The rollback step executed after the successful 0.1.11 -> 0.1.12 autoupdate and reported:

  • manifest covers 607 files
  • 0 differing files across 607 entries
  • restored registration and launchability
  • registry mismatch returned 103 and the no-failpoint recovery rerun completed
  • stale-version backup refusal passed
  • matching marker without Maka.exe refusal passed
  • hookless Quit retention and exact adoption recovery passed
  • registration-less/no-backup refusal passed
  • verified Abort-path rollback and its boundaries for 0.1.11 -> 0.1.12

The PR body now links this run. The old transactional/proven wording remains removed.

run: |
version="$(node -p "require('./apps/desktop/package.json').version")"
npm run verify:windows-installer-rollback -- \
"apps/desktop/release/Maka-${version}-win-x64.exe" \
apps/desktop/release-autoupdate-next
9 changes: 8 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ jobs:
runner: windows-2025
runs-on: ${{ matrix.runner }}
environment: release
timeout-minutes: 60
timeout-minutes: 75
defaults:
run:
# Windows runners default to pwsh; the release steps are written once,
Expand Down Expand Up @@ -222,6 +222,13 @@ jobs:
"apps/desktop/release/${{ needs.release-identity.outputs.exe }}" \
apps/desktop/release-autoupdate-next

- name: Prove deterministic mid-install failure rollback
if: matrix.platform == 'windows'
run: |
npm run verify:windows-installer-rollback -- \
"apps/desktop/release/${{ needs.release-identity.outputs.exe }}" \
apps/desktop/release-autoupdate-next

- name: Stage the exact product artifact group
run: >-
node scripts/product-release-artifacts.mjs stage
Expand Down
Loading