feat(providers): add Atlas Cloud integration - #2659
Conversation
Signed-off-by: binyangzhu000-sudo <224954946+binyangzhu000-sudo@users.noreply.github.com>
Astro-Han
left a comment
There was a problem hiding this comment.
Thanks for taking the time to prepare this integration and its tests.
Before I review the implementation further, I need to resolve the product and provenance questions first.
Maka already supports arbitrary OpenAI Chat-compatible services through the built-in Custom relay (OpenAI Chat-compatible) provider, including a custom base URL, API key, model discovery, and per-model capability declarations. Atlas Cloud’s own documentation describes its LLM endpoint as OpenAI-compatible, so it appears to be usable today with:
https://api.atlascloud.ai/v1
Adding a ready, first-class provider is therefore not only a transport change. It creates a permanent catalog and support contract for the endpoint, fallback model, capability metadata, display copy, and future compatibility maintenance. I currently cannot find a linked Maka user request or a concrete Atlas-specific incompatibility that the existing custom-provider path cannot express.
I also noticed that this account has recently opened a large number of Atlas Cloud integration PRs across many unrelated repositories and has contributed to repositories under the AtlasCloudAI organization. I do not want to make assumptions about that relationship, but transparency matters for a provider-catalog decision. Could you please disclose:
- any affiliation, sponsorship, compensation, or other relationship with Atlas Cloud;
- whether automation or generative AI materially produced this contribution;
- the concrete Maka user demand motivating a first-class entry;
- the specific behavior that cannot be supported through Maka’s existing OpenAI-compatible provider;
- inspectable, redacted evidence for the claimed live discovery, text-generation, and tool-execution verification.
Unless there is a genuine protocol or product requirement that the shared path cannot satisfy, my current preference is to keep Atlas Cloud on the generic OpenAI-compatible seam rather than add a parallel first-class provider contract. This is not a judgment on the service itself, and I am open to being shown a concrete incompatibility or user need that changes that conclusion.
中文对照
感谢你准备这项集成及相关测试。
在继续审查具体实现之前,我需要先明确产品需求和贡献来源。
Maka 已经通过内置的“Custom relay (OpenAI Chat-compatible)”支持任意 OpenAI Chat 兼容服务,包括自定义 Base URL、API key、模型发现和逐模型能力声明。Atlas Cloud 官方文档也将其 LLM endpoint 描述为 OpenAI-compatible,因此目前应当已经可以使用:
https://api.atlascloud.ai/v1
增加一个 ready 状态的一级 Provider 并不只是传输层改动。它会为 endpoint、默认模型、能力元数据、展示文案以及未来兼容性建立长期的目录和维护契约。目前我没有找到关联的 Maka 用户需求,也没有看到现有通用 Provider 无法表达的 Atlas 特有不兼容行为。
我还注意到,这个账号最近向许多互不相关的仓库提交了大量 Atlas Cloud 集成 PR,并且参与了 AtlasCloudAI 组织下仓库的贡献。我不希望对双方关系作未经证实的推断,但 Provider 目录决策需要透明度。请说明:
- 是否与 Atlas Cloud 存在从属、赞助、报酬或其他关系;
- 本次贡献是否实质使用了自动化或生成式 AI;
- 将 Atlas 作为一级入口所对应的具体 Maka 用户需求;
- Maka 现有 OpenAI-compatible Provider 无法支持的具体行为;
- PR 中所称实时模型发现、文本生成和工具执行验证的可检查、已脱敏证据。
除非确实存在共享路径无法满足的协议或产品需求,否则我目前倾向于继续通过通用 OpenAI-compatible 扩展点支持 Atlas Cloud,而不是增加一个平行的一级 Provider 契约。这不是对服务本身的评价;如果有具体的不兼容行为或用户需求,我愿意据此重新判断。
Disclosure: Codex assisted with repository and public-contribution-pattern analysis and drafted this comment. I reviewed the cited evidence, determined the product and provenance questions, and made the decision to request clarification.
|
/agentic_review |
Code Review by Qodo
1. Multimodal model marked text-only
|
| 'qwen/qwen3.8-max': { | ||
| displayName: 'Qwen3.8 Max', | ||
| lifecycle: 'active', | ||
| capabilities: { chat: true, reasoning: true, functionCalling: true }, |
There was a problem hiding this comment.
1. Multimodal model marked text-only 🐞 Bug ≡ Correctness
The Atlas Cloud metadata omits vision: true and image input modalities for qwen/qwen3.8-max, so resolveModelVisionSupport() returns false and the runtime replaces image attachments with a “model does not support image input” notice. This contradicts Atlas Cloud's description of this exact model as supporting multimodal applications.
Agent Prompt
## Issue description
Atlas Cloud's `qwen/qwen3.8-max` metadata omits vision and image-input declarations, causing the runtime to reject images for a multimodal model.
## Issue Context
Use the existing static metadata seam: add `vision: true` and `modalities: { input: ['text', 'image'], output: ['text'] }`, plus a focused regression assertion. Deletion or consolidation cannot restore the missing provider-specific capability; this adds no new public surface or authority because the static metadata entry is already authoritative for Atlas Cloud, with only a small test-maintenance burden.
## Fix Focus Areas
- packages/core/src/model-metadata.ts[412-418]
- packages/core/src/__tests__/model-metadata.test.ts[1-130]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
This PR makes Atlas Cloud selectable in the Desktop provider catalog. Could you please add a screenshot showing Atlas Cloud in the catalog and its connection or model-selection surface? Please sanitize any account or credential details. One annotated screenshot is fine. Thanks! Posted by Codex on behalf of Astro-Han. |
|
Heads up — this has drifted into conflict with Worth knowing before you rebase: #3397 landed on 2026-08-22 and added ASF license headers across ~2685 files, so a rebase will touch more than you'd expect, and any file you add now needs a header ( I'd like to review this — just ping me once it's rebased and CI is green. |
|
Hi — this PR conflicts with current I tested a rebase onto current
These are real source conflicts, so they need your judgement rather than a mechanical rebase — please rebase onto current Thanks for the contribution — happy to help if any conflict is unclear. AI-assisted maintenance note, not a review. It does not count as the required human review under |
Summary
qwen/qwen3.8-maxVerification
npm --workspace @maka/core test(805 passed)npm run buildnpm run typechecknpm run lintnpm run formatqwen/qwen3.8-maxChecklist
Does this PR entail a change in behavior?