KNOX-3280 - Added Knoxshell Tests#1183
Draft
moresandeep wants to merge 4 commits into
Draft
Conversation
moresandeep
marked this pull request as draft
March 23, 2026 18:02
moresandeep
marked this pull request as ready for review
March 24, 2026 14:40
Contributor
|
Hi @moresandeep - is this still needed? If not, can you please close this PR? |
# Conflicts: # .github/workflows/compose/docker-compose.yml
Add module and class docstrings, fix import order, strip trailing whitespace, wrap long assert lines, and pass explicit check=False to subprocess.run so the file satisfies the pylint *.py step added on master. Test logic is unchanged.
moresandeep
marked this pull request as draft
July 22, 2026 17:44
Contributor
Author
|
Converting to draft as we are waiting on #1181 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3280 - Added Knoxshell Tests
** Needs #1181 to be fixed before this goes in**
What changes were proposed in this pull request?
This PR adds support for KnoxShell integration tests.
How was this patch tested?
This patch was tested locally.
Integration Tests