test(integration): spec clients-table durability across node restart#3736
Open
hubcio wants to merge 1 commit into
Open
test(integration): spec clients-table durability across node restart#3736hubcio wants to merge 1 commit into
hubcio wants to merge 1 commit into
Conversation
A node reboot wipes the VSR clients table, so a client that keeps its (client, session, request) identity cannot continue: a retry of an already-committed request is silently dropped as a gap or re-applied, and the next request id bounces off the unknown session. The Rust SDK cannot exercise this (it re-registers under a fresh identity on every disconnect), so the scenarios are hand-crafted raw TCP frames, kept ignored until clients-table persistence and the server half of session resume land; the module doc carries the fix plan. Also drop the cluster ping matrix stub: its module was gated cfg(not(vsr)) and the test ignored, so it never ran in any mode.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3736 +/- ##
=============================================
- Coverage 74.35% 40.24% -34.12%
Complexity 950 950
=============================================
Files 1303 1301 -2
Lines 148712 129051 -19661
Branches 124223 104562 -19661
=============================================
- Hits 110579 51931 -58648
- Misses 34658 74377 +39719
+ Partials 3475 2743 -732
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A node reboot wipes the VSR clients table, so a client that keeps
its (client, session, request) identity cannot continue: a retry
of an already-committed request is silently dropped as a gap or
re-applied, and the next request id bounces off the unknown
session. The Rust SDK cannot exercise this (it re-registers under
a fresh identity on every disconnect), so the scenarios are
hand-crafted raw TCP frames, kept ignored until clients-table
persistence and the server half of session resume land; the
module doc carries the fix plan.
Also drop the cluster ping matrix stub: its module was gated
cfg(not(vsr)) and the test ignored, so it never ran in any mode.