fix(connectors): fix postgres source CDC producing no messages#3640
Merged
mmodzelewski merged 10 commits intoJul 23, 2026
Conversation
mattp5657
marked this pull request as ready for review
July 9, 2026 23:35
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3640 +/- ##
=============================================
- Coverage 74.35% 40.98% -33.37%
Complexity 950 950
=============================================
Files 1303 1301 -2
Lines 148712 129522 -19190
Branches 124221 105033 -19188
=============================================
- Hits 110569 53089 -57480
- Misses 34668 73663 +38995
+ Partials 3475 2770 -705
🚀 New features to boost your workflow:
|
Contributor
|
i think this is somewhat related to #3313 |
Contributor
|
@mmodzelewski could you please check this one? |
mmodzelewski
requested changes
Jul 15, 2026
mmodzelewski
left a comment
Member
There was a problem hiding this comment.
Thanks, @mattp5657. The change looks solid, I've posted a few comments where the code could be improved.
added 6 commits
July 18, 2026 20:25
Contributor
Author
|
These should be fixed, let me know if you have any other feedback :) |
Contributor
Author
|
/ready |
mmodzelewski
approved these changes
Jul 23, 2026
mmodzelewski
left a comment
Member
There was a problem hiding this comment.
Thanks, @mattp5657, approved
hubcio
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
Relates to #3582
Rationale
Builtin CDC mode currently produces zero messages against a real
database - wrong plugin/read-path pairing, and a parser matching a
format no real Postgres output plugin emits. This PR is scoped to
getting CDC actually working and provably correct, nothing more.
I have reduce the scope of this specific PR for reviewability, in the future
would look to create issues and work on these issues:
pgoutputas the long-term plugin - real binary decoder + streamingconnection is a much bigger lift;
test_decodingunblocks correctnesstoday. Target once
cdc_backend = "pg_replicate"gets picked up.no LSN tracked) - needs its own review since it touches the
state-persistence contract. Follow-up: #TODO.
commit time,
old_dataunpopulated) - mechanical, separate PR.What changed?
Before: wrong slot plugin, a parser matching a format no real Postgres
output emits, and invalid setup SQL - CDC produced zero messages, and
several related bugs failed silently too. After: parser rewritten
against real captured output, setup/poll SQL fixed and bounded, and
those failure modes now work correctly or fail loudly. Covered by
corpus-driven unit tests plus integration tests against a live
wal_level=logicalcontainer.test_decodingoutputLocal Execution
AI Usage
Claude was used to help generate and review this PR.