-
Notifications
You must be signed in to change notification settings - Fork 566
ci: enable GitHub merge queue with required CI gates #3195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,6 +25,7 @@ name: "ASF Allowlist Check" | |
|
|
||
| on: | ||
| pull_request: | ||
| merge_group: | ||
| push: | ||
| branches: | ||
| - main | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,19 +22,7 @@ on: | |
| branches: | ||
| - main | ||
| pull_request: | ||
| paths: | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we need to get rid of all i think this is a good tradeoff in order to enable merge queue. and we can look at optimizations at a later time |
||
| - '**' # Include all files and directories in the repository by default. | ||
| - '!.github/ISSUE_TEMPLATE/**' # Exclude files and directories that don't impact tests or code like templates, metadata, and documentation. | ||
| - '!dev/release/**' | ||
| - '!website/**' | ||
| - '!.asf.yml' | ||
| - '!.gitattributes' | ||
| - '!.gitignore' | ||
| - '!CONTRIBUTING.md' | ||
| - '!CHANGELOG.md' | ||
| - '!LICENSE' | ||
| - '!NOTICE' | ||
| - '!README.md' | ||
| merge_group: | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }} | ||
|
|
@@ -121,3 +109,17 @@ jobs: | |
| HF_DATASET: ${{ secrets.HF_DATASET }} | ||
| run: | | ||
| make test | ||
|
|
||
| bindings-python-ci-required: | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add this so we dont need to add all the checks to the otherwise we'd have to keep them in sync |
||
| if: ${{ always() }} | ||
| needs: [check-python, test] | ||
| runs-on: ubuntu-slim | ||
| steps: | ||
| - name: Verify Bindings Python CI jobs succeeded | ||
| env: | ||
| RESULTS: ${{ join(needs.*.result, ' ') }} | ||
| run: | | ||
| read -ra results <<< "$RESULTS" | ||
| for result in "${results[@]}"; do | ||
| test "$result" = "success" | ||
| done | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,7 +23,7 @@ on: | |
| push: | ||
| branches: ["main"] | ||
| pull_request: | ||
| branches: ["**"] | ||
| merge_group: | ||
|
|
||
| permissions: {} | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allows this workflow to run in merge queue