Skip to content

fix(sql): tolerate concurrent catalog migrations - #3071

Draft
manuzhang wants to merge 1 commit into
apache:mainfrom
manuzhang:fix-concurrent-sql-catalog-migration
Draft

fix(sql): tolerate concurrent catalog migrations#3071
manuzhang wants to merge 1 commit into
apache:mainfrom
manuzhang:fix-concurrent-sql-catalog-migration

Conversation

@manuzhang

Copy link
Copy Markdown
Member

Which issue does this PR close?

  • None.

What changes are included in this PR?

SQL catalog schema detection now probes the V1-only column directly, and V0-to-V1 migration tolerates a competing catalog instance completing the same migration first. A failed DDL is accepted only after re-detection confirms that V1 is installed.

This change was extracted from #2773 so the Unknown-type work can be reviewed independently.

Are these changes tested?

  • Added a concurrent SQLite migration regression using two catalog pools.
  • cargo test -p iceberg-catalog-sql --lib (49 passed)
  • cargo fmt --all -- --check
  • cargo clippy -p iceberg-catalog-sql --all-targets --all-features -- -D warnings

AI Disclosure

This PR was prepared with assistance from Codex.

Co-authored-by: Codex <codex@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant