Various fixes#685
Closed
notroj wants to merge 7 commits into
Closed
Conversation
* modules/metadata/mod_remoteip.c (remoteip_process_v2_header): Set conn_conf->client_addr and client_ip for the LOCAL case, matching the v1 UNKNOWN path. Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* modules/ssl/ssl_engine_ocsp.c (determine_responder_uri): Check u->scheme is non-NULL before calling ap_cstr_casecmp(), since apr_uri_parse() can succeed with a NULL scheme for scheme-less URIs. Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* modules/metadata/mod_cern_meta.c (scan_meta_file): Return a 500 error if a framing header is found in a .meta file rather than merging it into the response headers. Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* modules/ldap/util_ldap.c: Hold the LDAP cache lock continuously from URL node fetch through child cache access, closing the window where a concurrent request could free the node between unlock and re-lock. Re-fetch the URL node under the lock for write-back paths. Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* modules/ssl/ssl_engine_kernel.c (set_challenge_creds): Return rv rather than APR_SUCCESS unconditionally, so credential setup failures are propagated to the ALPN selection callback. Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* modules/filters/mod_substitute.c (set_max_line_length): Check that the parsed value does not exceed APR_INT64_MAX / multiplier before applying the K/M/G suffix, to avoid signed integer overflow UB. Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* modules/filters/mod_substitute.c (set_pattern): Guard the pre-incrementing delimiter scan loops with a NUL check, preventing a read past the end of the allocation when the from or to field has no closing delimiter. Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Jul 17, 2026
* modules/metadata/mod_remoteip.c (remoteip_process_v2_header): Set conn_conf->client_addr and client_ip for the LOCAL case, matching the v1 UNKNOWN path. Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com> GitHub: PR #685 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1936258 13f79535-47bb-0310-9956-ffa450edef68
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Jul 17, 2026
* modules/ssl/ssl_engine_ocsp.c (determine_responder_uri): Check u->scheme is non-NULL before calling ap_cstr_casecmp(), since apr_uri_parse() can succeed with a NULL scheme for scheme-less URIs. Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com> GitHub: PR #685 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1936259 13f79535-47bb-0310-9956-ffa450edef68
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Jul 17, 2026
* modules/metadata/mod_cern_meta.c (scan_meta_file): Return a 500 error if a framing header is found in a .meta file rather than merging it into the response headers. Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com> GitHub: PR #685 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1936260 13f79535-47bb-0310-9956-ffa450edef68
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Jul 17, 2026
* modules/ldap/util_ldap.c: Hold the LDAP cache lock continuously from URL node fetch through child cache access, closing the window where a concurrent request could free the node between unlock and re-lock. Re-fetch the URL node under the lock for write-back paths. Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com> GitHub: PR #685 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1936261 13f79535-47bb-0310-9956-ffa450edef68
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Jul 17, 2026
* modules/ssl/ssl_engine_kernel.c (set_challenge_creds): Return rv rather than APR_SUCCESS unconditionally, so credential setup failures are propagated to the ALPN selection callback. Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com> GitHub: PR #685 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1936262 13f79535-47bb-0310-9956-ffa450edef68
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Jul 17, 2026
* modules/filters/mod_substitute.c (set_max_line_length): Check that the parsed value does not exceed APR_INT64_MAX / multiplier before applying the K/M/G suffix, to avoid signed integer overflow UB. Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com> GitHub: PR #685 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1936263 13f79535-47bb-0310-9956-ffa450edef68
Collaborator
Author
|
Merged as above. |
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Jul 17, 2026
* modules/filters/mod_substitute.c (set_pattern): Guard the pre-incrementing delimiter scan loops with a NUL check, preventing a read past the end of the allocation when the from or to field has no closing delimiter. Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com> GitHub: closes #685 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1936264 13f79535-47bb-0310-9956-ffa450edef68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.