feat(ui): establish component boundary with accessible tabs - #540
Open
FenjuFu wants to merge 3 commits into
Open
feat(ui): establish component boundary with accessible tabs#540FenjuFu wants to merge 3 commits into
FenjuFu wants to merge 3 commits into
Conversation
Define the component, CVA, theme and browser-test migration contracts. Ratchet existing Ionic imports and migrate shared entity datatable tabs to an app-owned CDK-backed primitive with keyboard and ARIA contract tests. Refs apache#530 Signed-off-by: FenjuFu <92919259+FenjuFu@users.noreply.github.com>
Make the initial UI import instructions agree with the new boundary: feature/shared code uses app-owned primitives, existing imports follow the migration baseline, and direct vendor imports belong to UI implementations. Signed-off-by: FenjuFu <92919259+FenjuFu@users.noreply.github.com>
Complete the mocked business-date endpoint and attach desktop/narrow screenshots after the tab panel stops loading. Product source remains unchanged. Signed-off-by: FenjuFu <92919259+FenjuFu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Shared custom-field tabs now use an app-owned component and test contract. Arrow keys move focus without fetching a table; Enter/Space activates the selected table. Native buttons and CDK handle keyboard navigation, disabled items and RTL, while the feature receives a table-name string and owns loading the panel.
This also establishes the first migration increment from #530: ADR 0005 specifies the complete component/CVA value, keyboard/ARIA, browser-helper, theming and rollout contracts; the Ionic import ratchet records existing use while rejecting new unsuppressed dependencies outside UI implementations. Existing Material/i18n restrictions and other-rule allowances are preserved. AGENTS.md and STYLE.md direct new feature/shared code through app/ui.
Refs #530. Remaining tab strips, popup controls, form CVAs, cosmetic primitives, deployment-token expansion and legacy browser helpers remain under the overall migration issue. This PR delivers the boundary and one independently verifiable behavioural primitive; it does not close that issue.
Verification
Final head:
e992e9b88315455bcd310dc6941946e3804f7e49.Local: 17 rendered Angular unit/integration tests and 3 ESLint boundary tests passed. App/E2E TypeScript checks, changed-source ESLint, formatting and git diff checks passed. Other lint-rule allowances were compared with the base and preserved.
Full fork CI passed on this head, including full unit suites, full lint/suppression pruning, production/container builds, API drift, translations, security, GA and license/RAT checks.
Full fork E2E passed on the same head: all mocked and real-Fineract shards, mobile and two-factor authentication. The new custom-field cases exercise the app-owned keyboard/panel contract at 1280px and 390px; they use mocked group data and attach screenshots after loading completes.
All three PR commits have matching FenjuFu noreply sign-offs and valid GitHub signatures. No generated API files were hand-edited. The upstream signed-commit check passed.
Upstream CI, E2E and CodeQL still require maintainer approval. The fork results above are independent evidence.
Screenshots
Unmodified image attachments from the passing new CI browser cases, showing the custom-field region after the panel finishes loading. Screenshots are stored on a separate review branch.
Desktop, 1280px viewport
Narrow, 390px viewport
AI assistance (optional)
Tool: Codex.
Harness / workflow: assisted implementation and review, targeted local checks, and full fork GitHub Actions validation.
Checklist
I did not hand-edit generated files under src/app/api/.
Feature translation uses the core adapter; DOM/focus behaviour is confined to the app/ui primitive.
User-facing static strings use translation keys; registered table names remain user data.
Added rendered unit, import-boundary and browser contract tests.
UI changes have browser coverage; full mocked and real-backend suites passed.
Commits are signed and contain matching sign-offs.
Followed the AI-assisted contributions guidance.