Skip to content

fix(clients): fix client list search for entity clients (#534) - #537

Open
subhranshudash13-dotcom wants to merge 2 commits into
apache:mainfrom
subhranshudash13-dotcom:fix/534-entity-client-search
Open

fix(clients): fix client list search for entity clients (#534)#537
subhranshudash13-dotcom wants to merge 2 commits into
apache:mainfrom
subhranshudash13-dotcom:fix/534-entity-client-search

Conversation

@subhranshudash13-dotcom

@subhranshudash13-dotcom subhranshudash13-dotcom commented Sep 9, 2026

Copy link
Copy Markdown

What and why :

The main Clients list was passing a hardcoded legalForm value of 1, which restricted the results to Person clients and excluded Entity clients.
This change removes the hardcoded value so the main client list is no longer restricted to a specific legal form and can return both Person and Entity clients.
Closes #534
Unblocks #377

Verification :

  • Added src/app/features/clients/clients-list.component.test.ts to cover the getClients() call without a hardcoded legalForm.
  • Added seedEntityClient in e2e/utils/seed-api.ts and an E2E regression test in e2e/client.spec.ts covering Entity client visibility in the main /clients list.
  • Ran the repository validation checks successfully:
    • node scripts/check-icons.mjs
    • node scripts/check-translations.mjs
    • node scripts/check-a11y-names.mjs
    • node scripts/check-route-permissions.mjs
    • node scripts/check-nav-ids.mjs
    • node scripts/check-api-surface.mjs
    • npx prettier --check on touched files
    • node --test "scripts/*.test.mjs"
    • node --test "eslint-rules/*.test.js"
  • The E2E regression test has been added but has not yet been run locally against the Docker/Fineract backend.

Screenshots :

Not applicable — this is a non-visual fix to the client list query.

Checklist :

  • I did not hand-edit generated files under src/app/api/.
  • New component or service code uses the adapter boundary in src/app/core/adapters/ instead of direct browser globals or imperative third-party APIs.
  • User-facing strings use translation keys.
  • I added or updated tests appropriate to this change, or explained why tests were not needed.
  • UI workflow changes include suitable e2e coverage, including real-backend testing where relevant.
  • Commits are signed — see Commit Signing in CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Client search is hardcoding 1 as legal form i think we need to extend search

1 participant