fix(clients): fix client list search for entity clients (#534) - #537
Open
subhranshudash13-dotcom wants to merge 2 commits into
Open
fix(clients): fix client list search for entity clients (#534)#537subhranshudash13-dotcom wants to merge 2 commits into
subhranshudash13-dotcom wants to merge 2 commits into
Conversation
subhranshudash13-dotcom
force-pushed
the
fix/534-entity-client-search
branch
from
September 10, 2026 12:35
fb6e544 to
ad9533c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why :
The main Clients list was passing a hardcoded
legalFormvalue of1, which restricted the results to Person clients and excluded Entity clients.This change removes the hardcoded value so the main client list is no longer restricted to a specific legal form and can return both Person and Entity clients.
Closes #534
Unblocks #377
Verification :
src/app/features/clients/clients-list.component.test.tsto cover thegetClients()call without a hardcodedlegalForm.seedEntityClientine2e/utils/seed-api.tsand an E2E regression test ine2e/client.spec.tscovering Entity client visibility in the main/clientslist.node scripts/check-icons.mjsnode scripts/check-translations.mjsnode scripts/check-a11y-names.mjsnode scripts/check-route-permissions.mjsnode scripts/check-nav-ids.mjsnode scripts/check-api-surface.mjsnpx prettier --checkon touched filesnode --test "scripts/*.test.mjs"node --test "eslint-rules/*.test.js"Screenshots :
Not applicable — this is a non-visual fix to the client list query.
Checklist :
src/app/api/.src/app/core/adapters/instead of direct browser globals or imperative third-party APIs.