fix(i18n): rename advanced client search by FenjuFu · Pull Request #533 · apache/fineract-backoffice-ui

FenjuFu · 2026-09-08T07:27:26Z

What and why

Rename the client-scoped free-text search from “Advanced Client Search” to “Client Search” so its navigation label and page title accurately describe the capability currently exposed. Keep the English, Hindi, and Korean navigation labels aligned without changing routes, APIs, search behavior, or layout.

Closes #493

AI assistance was used for issue triage, translation consistency checks, and validation orchestration. I reviewed and take responsibility for the four-line content change and the reported verification results.

Verification

Parsed en.json, hi.json, and ko.json as JSON.
npm run i18n:check — 1,615 referenced keys checked; no missing keys.
Targeted Prettier check for the three translation files — passed.
npm run lint — passed.
npm run build — passed. The build retained the existing non-blocking header.component.ts 5.12 kB style-budget warning; this change does not touch that component.
git diff --check — passed.
No mocked or real Fineract backend was needed because this changes labels only and does not change a UI workflow or API request.

Screenshots

Not applicable — this is a text-only label correction with no layout or style change. The misleading pre-change screen is already captured in #493.

Checklist

I did not hand-edit generated files under src/app/api/.
No component or service code changed; the adapter-boundary item is not applicable.
User-facing strings use existing translation keys.
No new test was needed for a translation-value-only change; JSON, i18n, formatting, lint, and production-build checks cover the affected surface.
No UI workflow changed, so new e2e coverage and real-backend testing are not applicable.
The commit is signed and includes a matching DCO Signed-off-by trailer.

The page exposes one client-scoped free-text query, so align its navigation label and title with the capability it actually provides. Signed-off-by: FenjuFu <92919259+FenjuFu@users.noreply.github.com>

github-actions · 2026-09-08T07:56:11Z

E2E — mocked backend

🎭 E2E Tests

✅ All green — 350 passed · 0 failed · 1 skipped, across 28 spec files in 6m 45s.

By spec file

Spec	✅	⏭️	Time
accessibility.spec.ts	3	0	13.0s
all-functions-read-shortcut.spec.ts	5	0	8.9s
branded-deployment.spec.ts	9	0	17.5s
breadcrumb.spec.ts	2	0	5.5s
client-servicing-gaps.spec.ts	14	0	57.9s
client.spec.ts	1	0	3.5s
deployment-customization.spec.ts	19	0	33.6s
e2e-journey.spec.ts	81	0	2m 48s
feature-coverage.spec.ts	47	0	1m 39s
functional-coverage.spec.ts	42	0	1m 51s
global-search-nav-shortcuts.spec.ts	4	0	9.5s
global-search-navigation.spec.ts	8	0	19.2s
group-detail.spec.ts	6	0	23.5s
guidance-tour.spec.ts	5	1	12.7s
keyboard-shortcuts.spec.ts	5	0	9.5s
list-pagination.spec.ts	9	0	31.6s
loan-portfolio-summary.spec.ts	4	0	14.3s
client-empty-account-cta.spec.ts	1	0	7.0s
loan-product-down-payment.spec.ts	13	0	1m 4s
loan-schedule-type-gating.spec.ts	5	0	17.8s
loan-servicing-gaps.spec.ts	14	0	54.4s
rbac-feature-flag.spec.ts	11	0	18.5s
rbac-route-protection.spec.ts	18	0	1m 38s
report-enhancements.spec.ts	2	0	5.9s
reporting.spec.ts	2	0	4.4s
scheduler-jobs.spec.ts	3	0	10.5s
two-factor-authentication.spec.ts	10	0	17.1s
working-capital-loan-actions.spec.ts	7	0	31.7s

All 351 tests — click to expand

accessibility.spec.ts

✅ Runtime accessibility › client list has no blocking violations — 3.7s
✅ Runtime accessibility › client form has no blocking violations — 4.2s
✅ Runtime accessibility › create office dialog has no blocking violations — 5.0s

all-functions-read-shortcut.spec.ts

✅ ALL_FUNCTIONS_READ shortcut › grants read access to the Clients list without any explicit READ_CLIENT permission — 1.8s
✅ ALL_FUNCTIONS_READ shortcut › does not grant the Create Client action — 1.8s
✅ ALL_FUNCTIONS_READ shortcut › does not grant Create Client even combined with an explicit READ_CLIENT permission — 1.9s
✅ ALL_FUNCTIONS_READ shortcut › a user with the real CREATE_CLIENT permission still sees the button — 1.6s
✅ ALL_FUNCTIONS_READ shortcut › ALL_FUNCTIONS (full superuser) still sees the Create Client button — 1.9s

branded-deployment.spec.ts

✅ a fully branded deployment › wears the institution’s name and mark, not Fineract’s — 2.6s
✅ a fully branded deployment › carries the institution’s palette into its own chrome and into Ionic — 1.6s
✅ a fully branded deployment › drops the sections the institution does not run — 1.6s
✅ a fully branded deployment › renames and reorders entries to the institution’s vocabulary — 1.6s
✅ a fully branded deployment › offers the institution’s own systems beside Fineract’s screens — 1.6s
✅ a fully branded deployment › restates the labels the institution words differently — 1.6s
✅ a fully branded deployment › keeps a readable palette in dark mode, with a label colour to match — 2.5s
✅ a fully branded deployment › does not leak a light colour into the dark palette — 1.6s
✅ a fully branded deployment › reports no configuration defects for the published example — 2.8s

breadcrumb.spec.ts

✅ a single-crumb page shows no breadcrumb trail — 1.7s
✅ a nested page shows a trail, and the ancestor crumb navigates back — 3.8s

client-servicing-gaps.spec.ts

✅ Client transfers › proposing a transfer sends the destination, the date and the format that parses it — 4.4s
✅ Client transfers › a one-step transfer omits the date the platform refuses — 4.3s
✅ Client transfers › the client’s own office is not offered as a destination — 4.3s
✅ Client transfers › accepting a transfer sends a note and nothing else — 4.1s
✅ Client transfers › accepting with no note sends an empty body — 4.1s
✅ Client transfers › rejecting a transfer is offered while one is pending — 4.3s
✅ Client transfers › withdrawing is offered from on hold, which is the only way back — 4.1s
✅ Client transfers › answers to a transfer are not offered when none is pending — 3.4s
✅ Client staff and default savings account › assigning a member of staff sends the staff id — 4.5s
✅ Client staff and default savings account › unassigning echoes the current holder back, which the platform requires — 4.6s
✅ Client staff and default savings account › unassigning is not offered when nobody is assigned — 3.2s
✅ Client staff and default savings account › the assigned officer is shown on the header — 4.0s
✅ Client staff and default savings account › setting the default savings account sends the account id — 4.3s
✅ Undoing a rejection › posts the command name the platform recognises, not the menu identifier — 4.4s

client.spec.ts

✅ Client Management › should create a new client — 3.5s

deployment-customization.spec.ts

✅ with no overlay mounted › boots, keeps the shipped branding, and shows the full menu — 2.2s
✅ with no overlay mounted › does not ask for an overlay this deployment has not declared — 1.5s
✅ with no overlay mounted › logs no federation parse error on load — 1.5s
✅ branding › applies colour and density tokens to the document — 1.6s
✅ branding › recolours Ionic through the same tokens — 1.6s
✅ branding › renames the product in the header and the tab title — 3.5s
✅ branding › serves the deployment logo and names it after the deployment — 1.6s
✅ branding › refuses a fill that cannot carry the white text baked into the stylesheet — 1.6s
✅ branding › accepts a light accent and derives a dark label for it — 1.6s
✅ branding › ignores a token outside the published allow-list, and says so — 1.5s
✅ navigation › hides an entry named by its id — 1.6s
✅ navigation › does not hide an entry named by its labelKey — 2.2s
✅ navigation › renames and reorders entries — 1.6s
✅ navigation › adds an external entry that opens in a new tab — 1.6s
✅ navigation › nests an added entry under an existing group — 1.6s
✅ navigation › gates an added entry on permissions like any built-in one — 1.6s
✅ navigation › drops an external entry with no usable url rather than rendering a dead link — 2.2s
✅ layering › merges over config.json instead of replacing it — 1.6s
✅ layering › a malformed overlay leaves the application usable — 1.6s

e2e-journey.spec.ts

✅ E2E: Login Flow › should display login page with all required fields — 1.3s
✅ E2E: Login Flow › should have Sign In button disabled when fields are empty — 1.4s
✅ E2E: Login Flow › should enable Sign In when credentials are entered — 1.3s
✅ E2E: Login Flow › should redirect to dashboard after successful login — 2.2s
✅ E2E: Login Flow › should display language selector on login page — 1.4s
✅ E2E: Login Flow › should display API endpoint selector with value — 1.3s
✅ E2E: Dashboard › should display dashboard summary cards — 1.6s
✅ E2E: Dashboard › should display system health as Online — 1.6s
✅ E2E: Dashboard › should display pending approvals section — 2.2s
✅ E2E: Dashboard › should display loan and savings status distribution charts — 1.6s
✅ E2E: Dashboard › should display system operational status — 1.6s
✅ E2E: Dashboard › should have header with business date, render time, and logout — 1.6s
✅ E2E: Dashboard › should have sidebar toggle button — 1.9s
✅ E2E: Dashboard › should have global search bar in header — 2.6s
✅ E2E: Dashboard › should have Guide button in header — 1.6s
✅ E2E: Dashboard › should have dark mode toggle button — 1.5s
✅ E2E: Sidebar Navigation › should have all main navigation links — 1.6s
✅ E2E: Sidebar Navigation › should have Products section with sub-links — 1.7s
✅ E2E: Sidebar Navigation › should have Transfers section with sub-links — 1.6s
✅ E2E: Sidebar Navigation › should have Accounting section with sub-links — 1.6s
✅ E2E: Sidebar Navigation › should have Security section — 2.7s
✅ E2E: Sidebar Navigation › should have Settings section — 1.7s
✅ E2E: Sidebar Navigation › should have Organization section — 1.7s
✅ E2E: Sidebar Navigation › should have System section — 1.7s
✅ E2E: Sidebar Navigation › should navigate to all major pages via sidebar — 3.8s
✅ E2E: Offices › should display offices list with table — 1.9s
✅ E2E: Offices › should have Create Office button — 1.8s
✅ E2E: Offices › should navigate to office create form — 2.6s
✅ E2E: Offices › should validate office create form - save disabled when empty — 2.0s
✅ E2E: Offices › should fill office create form and enable save — 2.4s
✅ E2E: Offices › should cancel office creation and return to list — 2.1s
✅ E2E: Offices › should have search input on offices page — 1.8s
✅ E2E: Offices › should show edit button for each office — 1.9s
✅ E2E: Offices › should have pagination controls — 1.8s
✅ E2E: Clients › should display clients list page — 2.9s
✅ E2E: Clients › should display client data in table — 2.6s
✅ E2E: Clients › should show ACTIVE status badge — 1.9s
✅ E2E: Clients › should have Create Client button — 1.8s
✅ E2E: Clients › should show empty state when no clients exist — 1.9s
✅ E2E: Clients › should have search input and status filter — 2.0s
✅ E2E: Clients › should have pagination controls — 2.4s
✅ E2E: Client Creation › should navigate to client create form — 3.5s
✅ E2E: Client Creation › should display all required client form fields, across the wizard steps — 3.3s
✅ E2E: Client Creation › should display optional client form fields, across the wizard steps — 2.8s
✅ E2E: Client Creation › should have Next disabled until the current step is valid — 2.6s
✅ E2E: Client Creation › should populate office dropdown from API — 2.2s
✅ E2E: Client Creation › should fill client form and enable save on the last step — 3.3s
✅ E2E: Client Creation › should submit client and redirect to clients list — 4.3s
✅ E2E: Client Creation › should cancel client creation and return to clients list — 2.2s
✅ E2E: Client Creation › should have add office quick-action button — 2.1s
✅ E2E: Client Creation › should have help icons for form fields — 1.8s
✅ E2E: Client Creation › should have calendar buttons for date fields — 2.6s
✅ E2E: Client Creation › should have pre-filled dates in Submitted On and Activation Date — 2.6s
✅ E2E: Client Creation › should have Active checkbox checked by default — 3.2s
✅ E2E: Client Creation › should handle Entity legal form showing fullname field — 3.1s
✅ E2E: Loan Products Page › should display loan products list page — 1.9s
✅ E2E: Loan Products Page › should have Create Loan Product button — 1.9s
✅ E2E: Loan Products Page › should display table with correct headers — 1.9s
✅ E2E: Loan Products Page › should show empty state when no products exist — 1.8s
✅ E2E: Loan Products Page › should have search input — 2.9s
✅ E2E: Loan Products Page › should navigate to loan product create form — 2.1s
✅ E2E: Savings Products Page › should display savings products list page — 1.9s
✅ E2E: Other Products Pages › Fixed Deposit Products page loads — 1.9s
✅ E2E: Other Products Pages › Recurring Deposit Products page loads — 1.9s
✅ E2E: Other Products Pages › Share Products page loads — 1.9s
✅ E2E: Other Products Pages › Tax Components page loads — 1.9s
✅ E2E: Other Products Pages › Tax Groups page loads — 2.9s
✅ E2E: Other Products Pages › Floating Rates page loads — 1.9s
✅ E2E: Loans Portfolio › should display loans portfolio page — 1.9s
✅ E2E: Loans Portfolio › should have Create Loan Account button — 1.8s
✅ E2E: Loans Portfolio › should display table with correct headers — 1.8s
✅ E2E: Loans Portfolio › should show empty state when no loans exist — 1.9s
✅ E2E: Loans Portfolio › should have search input — 2.4s
✅ E2E: Loans Portfolio › should have pagination controls — 1.8s
✅ E2E: Header & Global Elements › should display Fineract logo and title in header — 1.6s
✅ E2E: Header & Global Elements › should display logged-in username — 1.6s
✅ E2E: Header & Global Elements › should display office name for user — 1.6s
✅ E2E: Header & Global Elements › should have Logout button — 1.6s
✅ E2E: Header & Global Elements › should have language selector in header — 2.2s
✅ E2E: Header & Global Elements › should display render time — 1.6s
✅ E2E: Header & Global Elements › should display business date — 1.6s

feature-coverage.spec.ts

✅ Navigation & Sidebar › all main navigation links are visible in sidebar — 2.1s
✅ Navigation & Sidebar › sidebar navigation routes to correct pages — 3.2s
✅ Navigation & Sidebar › navigating to /accounting redirects to /accounting/chart-of-accounts — 3.7s
✅ Navigation & Sidebar › navigating to /organization redirects to /organization/offices — 2.9s
✅ Navigation & Sidebar › navigating to /system redirects to /system/data-tables — 2.9s
✅ Navigation & Sidebar › header shows logged-in user info — 1.6s
✅ Navigation & Sidebar › help tour button is visible and interactive — 2.5s
✅ Navigation & Sidebar › logout button is visible — 1.5s
✅ Navigation & Sidebar › language selector is present — 1.5s
✅ Dashboard › dashboard shows key metrics cards — 1.6s
✅ Dashboard › dashboard shows pending approvals section — 2.0s
✅ Dashboard › dashboard shows loan and savings status distribution — 1.6s
✅ Dashboard › dashboard shows system operational status — 2.2s
✅ Groups › groups page renders with title — 1.8s
✅ Groups › groups page has create button — 1.8s
✅ Centers › centers page renders with title — 2.2s
✅ Centers › centers page has create button — 2.2s
✅ Organization › offices page loads with list — 1.8s
✅ Organization › staff page loads — 1.8s
✅ Organization › funds page loads — 2.7s
✅ Organization › payment types page loads — 1.9s
✅ Accounting › chart of accounts loads — 1.8s
✅ Accounting › journal entries page loads — 2.5s
✅ Accounting › accounting closures loads — 1.9s
✅ Accounting › accounting rules loads — 2.8s
✅ Accounting › financial activity mappings loads — 1.9s
✅ Accounting › charges page loads — 1.8s
✅ Security › users page loads — 1.8s
✅ Security › roles page loads — 1.8s
✅ Security › audit logs page loads — 2.7s
✅ Products - Loan & Savings › loan products page loads — 1.8s
✅ Products - Loan & Savings › savings products page loads — 1.9s
✅ Products - Loan & Savings › tax components page loads — 1.8s
✅ Products - Loan & Savings › tax groups page loads — 1.9s
✅ Products - Loan & Savings › floating rates page loads — 2.4s
✅ Products - Loan & Savings › savings accounts page loads — 1.9s
✅ Settings › global configurations page loads — 1.8s
✅ Settings › holidays page loads — 2.2s
✅ Settings › working days page loads — 1.8s
✅ System › data tables page loads — 2.8s
✅ System › bulk import page loads — 1.9s
✅ System › delinquency page loads — 1.9s
✅ Tellers › tellers page loads with create button — 1.9s
✅ Transfers › account transfer page loads — 2.4s
✅ Transfers › standing instructions page loads — 1.8s
✅ Transfers › SI history page loads — 1.9s
✅ Embedded Fintech › asset owners page loads — 2.9s

functional-coverage.spec.ts

✅ Client CRUD Workflow › should complete full client creation flow — Person — 4.5s
✅ Client CRUD Workflow › should complete full client creation flow — Entity — 3.9s
✅ Client CRUD Workflow › should cancel client creation and return to list — 2.2s
✅ Client CRUD Workflow › should disable office and legal form in edit mode — 3.2s
✅ Client View & Status Transitions › should display client view with correct details — 3.9s
✅ Client View & Status Transitions › should show actions menu for pending client (status 100) — 3.4s
✅ Client View & Status Transitions › should show actions menu for active client (status 300) — 3.3s
✅ Client View & Status Transitions › should show actions menu for closed client (status 600) — 3.8s
✅ Client View & Status Transitions › should show New Account menu for active client — 3.4s
✅ Client View & Status Transitions › should navigate from client view to client list via breadcrumb — 3.0s
✅ Client View & Status Transitions › should navigate back from client view — 4.2s
✅ Client View Tabs › should display all expected tabs on client view — 3.0s
✅ Client View Tabs › should switch between client view tabs — 3.5s
✅ Search & Filter Interactions › should have search input on clients page and accept input — 1.9s
✅ Search & Filter Interactions › should have office filter on groups page — 2.5s
✅ Search & Filter Interactions › should have office filter on loans page — 2.2s
✅ Search & Filter Interactions › should have search input on charges page — 1.7s
✅ Navigation Flow Verification › should navigate full client lifecycle: list → create → back → list — 2.3s
✅ Navigation Flow Verification › should navigate from dashboard to all top-level pages via sidebar — 3.7s
✅ Navigation Flow Verification › should go from loan products → create → back — 2.2s
✅ Office CRUD › should validate office create form — save disabled when empty — 2.7s
✅ Office CRUD › should validate office create form — save enabled when filled — 2.4s
✅ Office CRUD › should cancel office creation — 2.1s
✅ Organization Create Flows › staff create form loads — 2.1s
✅ Organization Create Flows › funds create form loads — 1.9s
✅ Organization Create Flows › payment types create form loads — 1.9s
✅ Accounting CRUD › accounting closure create form loads — 3.0s
✅ Accounting CRUD › accounting rule create form loads — 2.0s
✅ Accounting CRUD › financial activity mapping create form loads — 2.0s
✅ Accounting CRUD › charge create form loads — 2.0s
✅ Accounting CRUD › chart of accounts create form loads — 2.2s
✅ Settings CRUD › global configurations page has editable toggle — 1.8s
✅ Settings CRUD › holiday create form loads — 3.0s
✅ Settings CRUD › working days page has save button — 1.8s
✅ System CRUD › data table create form loads — 2.0s
✅ System CRUD › delinquency page has create buttons for ranges and buckets — 1.9s
✅ Security CRUD › role create form loads — 1.9s
✅ Security CRUD › audit logs search form has date range — 2.2s
✅ Security CRUD › audit logs list exports the loaded page as CSV — 2.7s
✅ Reporting — Run Report Flow › should navigate to report and verify report parameters — 2.6s
✅ Teller CRUD › teller create form loads — 2.1s
✅ Create Office Dialog from Client Form › should open create office dialog from client create form — 2.4s

global-search-nav-shortcuts.spec.ts

✅ Global search navigation shortcuts › offers a settings page the entity search cannot return — 1.9s
✅ Global search navigation shortcuts › navigates to the page behind a shortcut — 2.0s
✅ Global search navigation shortcuts › keeps the results open across the mousedown that starts a click, so a slow render cannot race the dropdown closed — 3.2s
✅ Global search navigation shortcuts › withholds a shortcut the user has no permission to reach — 2.3s

global-search-navigation.spec.ts

✅ Global search navigation › does not query the backend for a single character — 2.5s
✅ Global search navigation › sends one request for a phrase typed straight through — 3.0s
✅ Global search navigation › opens the client behind a client result — 2.2s
✅ Global search navigation › opens the loan behind a loan result — 2.1s
✅ Global search navigation › opens the savings account behind a savings result — 2.3s
✅ Global search navigation › clears the query and closes the dropdown after a selection — 2.6s
✅ Global search navigation › closes the dropdown when focus leaves without a selection — 2.0s
✅ Global search navigation › shows nothing rather than an empty dropdown when there are no matches — 2.5s

group-detail.spec.ts

✅ Group detail › asks for the associations, and shows every member rather than only the active ones — 3.4s
✅ Group detail › closes a group with the reason id and a Fineract-formatted date — 5.4s
✅ Group detail › does not offer a client who is already a member, and associates the one it does — 4.0s
✅ Group detail › unassigns a committee role by the assignment id, not the role id — 3.4s
✅ Group detail › offers a retry when the group cannot be loaded — 3.7s
✅ Group detail › says so when no closure reason has been defined — 3.6s

guidance-tour.spec.ts

✅ the guided tour › highlights the System Status card, not the sidebar, on the dashboard tour — 2.1s
✅ the guided tour › presents the card as a dialog named and described by its own copy — 1.6s
✅ the guided tour › announces the step counter as a polite live region — 2.1s
✅ the guided tour › closes on Escape and hands focus back to the Guide button — 2.6s
✅ the guided tour › names an unmatched route after itself instead of handing it the dashboard tour — 2.9s
⏭️ the guided tour at a phone viewport › opens from the overflow menu as a full-width bottom sheet — 1.5s

keyboard-shortcuts.spec.ts

✅ Alt+C jumps straight to Create Client from anywhere — 1.8s
✅ Alt+G jumps to Create Group — 1.8s
✅ Alt+E jumps to Create Center — 2.7s
✅ Alt+H opens the guidance tour for the current page — 1.6s
✅ typing in the global search box does not trigger the Create Client shortcut — 1.6s

list-pagination.spec.ts

✅ List pagination › advances through pages and back again — 3.1s
✅ List pagination › jumps to the last page — 3.7s
✅ List pagination › returns to the first page when a filter changes — 3.6s
✅ List pagination › returns to the first page when searching — 3.7s
✅ Profile › renders the signed-in user rather than hanging on a spinner — 3.6s
✅ Profile › shows an error when the profile cannot be loaded — 3.3s
✅ List load failure › reports the failure and reloads when the user retries — 3.4s
✅ List load failure › calendars: reports the failure and reloads when the user retries — 3.7s
✅ List load failure › accounting rules: reports the failure and reloads when the user retries — 3.4s

loan-portfolio-summary.spec.ts

✅ Loan Portfolio Summary › searching sends entities: loans and shows the grouped results — 3.1s
✅ Loan Portfolio Summary › Edit Parameters returns from the results view to the filter form — 3.9s
✅ Loan Portfolio Summary › checking the outstanding-amount filter sends the between min/max values — 3.1s
✅ Loan Portfolio Summary › switching to a single-value comparison condition sends one value — 4.2s

client-empty-account-cta.spec.ts

✅ empty account tabs offer the matching creation action — 7.0s

loan-product-down-payment.spec.ts

✅ Loan product down payment and tranches › down payment is offered only for a progressive product — 3.8s
✅ Loan product down payment and tranches › the percentage and auto-repayment appear only once down payment is on — 4.7s
✅ Loan product down payment and tranches › multi-tranche disbursement reveals its tranche count, on either engine — 3.0s
✅ Loan product down payment and tranches › submits the down payment and tranche settings it was given — 4.3s
✅ Loan product down payment and tranches › does not send a down payment on a cumulative product — 5.7s
✅ Loan product down payment and tranches › income recognition is offered only for a progressive product — 3.8s
✅ Loan product down payment and tranches › the capitalisation details appear only once it is on — 3.9s
✅ Loan product down payment and tranches › submits the income recognition settings it was given — 4.8s
✅ Loan product down payment and tranches › does not send income recognition on a cumulative product — 5.2s
✅ Loan product down payment and tranches › interest recalculation reveals its mandatory settings only once it is on — 3.1s
✅ Loan product down payment and tranches › the rest interval appears only when the frequency is not the repayment period — 14.9s
✅ Loan product down payment and tranches › submits the interest recalculation settings it was given — 3.3s
✅ Loan product down payment and tranches › does not send recalculation settings once it is switched back off — 3.3s

loan-schedule-type-gating.spec.ts

✅ Loan schedule type gating › a cumulative loan offers neither progressive-only tab, and fetches neither — 3.7s
✅ Loan schedule type gating › a progressive loan shows only the capabilities it actually has — 3.3s
✅ Loan schedule type gating › a progressive loan with both capabilities shows both — 3.4s
✅ Loan schedule type gating › a charged-off loan says so and offers the reversal instead — 4.0s
✅ Loan schedule type gating › a healthy loan offers charge-off and no marker — 3.4s

loan-servicing-gaps.spec.ts

✅ Loan servicing gaps › edits an interest pause through PUT while preserving its existing dates — 3.7s
✅ Loan servicing gaps › undo approval sends an empty body, without the locale the platform refuses — 5.2s
✅ Loan servicing gaps › undo approval carries the reason when one was given — 4.1s
✅ Loan servicing gaps › undo approval is offered only while the loan is approved — 3.3s
✅ Loan servicing gaps › the delinquency tab shows the summary the loan carries and the tags it fetches — 3.8s
✅ Loan servicing gaps › the data-only tabs stay hidden when the loan carries nothing for them — 3.4s
✅ Loan servicing gaps › each data-only tab appears and renders once the loan carries its data — 3.6s
✅ Loan servicing gaps › disburse to savings sends the date and amount, with the platform date format — 4.8s
✅ Loan servicing gaps › disburse to savings is offered only on an approved loan — 3.4s
✅ Loan servicing gaps › unassign loan officer sends the date, and appears only when one is assigned — 4.2s
✅ Loan servicing gaps › unassign loan officer is hidden on a loan with no officer — 3.6s
✅ Loan servicing gaps › undo last disbursal appears only on a multi-disbursal loan, and sends an empty body — 4.2s
✅ Loan servicing gaps › undo last disbursal is hidden on a single-disbursal loan — 3.4s
✅ Loan servicing gaps › close as rescheduled is offered on an active loan — 4.0s

rbac-feature-flag.spec.ts

✅ RBAC permission gating (rbacEnabled = true) › a limited user does not see permission-gated nav groups — 1.5s
✅ RBAC permission gating (rbacEnabled = true) › a user with READ_USER sees only the Security entries that permission covers — 1.5s
✅ RBAC permission gating (rbacEnabled = true) › the Security group fills in as the user is granted each of its permissions — 1.4s
✅ RBAC permission gating (rbacEnabled = true) › a superuser (ALL_FUNCTIONS) sees all permission-gated groups — 1.6s
✅ RBAC institution-feature gating (rbacEnabled = true) › universal institution shows Groups, Centers and Collection Sheet — 1.6s
✅ RBAC institution-feature gating (rbacEnabled = true) › commercial bank (cb) hides all group-lending features — 2.3s
✅ RBAC institution-feature gating (rbacEnabled = true) › credit union (cu) shows Groups but hides Centers and Collection Sheet — 1.6s
✅ rbacEnabled = false › restores the pre-RBAC behaviour of showing everything — 1.6s
✅ deployment navigation overrides › removes the entries the deployment names by id, leaving the rest alone — 1.6s
✅ deployment navigation overrides › ignores a labelKey where an id is required — 1.6s
✅ deployment navigation overrides › removes them even where RBAC is off — 2.4s

rbac-route-protection.spec.ts

✅ route authorization › a superuser reaches every sampled route and sees the full navigation — 12.8s
✅ route authorization › a single-module user is confined to that module — 9.3s
✅ route authorization › a read-only user gets the lists and not the forms — 11.1s
✅ route authorization › a user with an empty permission list is refused everywhere and the app still works — 8.4s
✅ route authorization › a session carrying no permissions field is treated as carrying none — 5.8s
✅ route authorization › an unrecognised permission code grants nothing — 4.9s
✅ route authorization › an unauthenticated visitor is asked to sign in, not told they are forbidden — 6.2s
✅ route authorization › a deployment with RBAC turned off behaves as it did before the guard — 7.1s
✅ the Access Denied page › says what happened, under a single heading — 4.0s
✅ the Access Denied page › moves focus to the heading, since the user did not ask to come here — 3.1s
✅ the Access Denied page › announces itself politely — 3.2s
✅ the Access Denied page › names the permissions the screen wanted, so the user can ask for them — 3.7s
✅ the Access Denied page › offers a way back that the user is allowed to take — 3.3s
✅ the Access Denied page › is reachable by keyboard alone — 3.2s
✅ permission feedback › a visible nav entry says what the user can do in that module — 1.4s
✅ permission feedback › a nav entry carries no hint when there is nothing specific to say — 1.5s
✅ navigation and routes agree › a hidden menu entry is also refused by URL, and a shown one is not — 6.0s
✅ navigation and routes agree › the create button is withheld from a user whose create route would refuse them — 3.3s

report-enhancements.spec.ts

✅ Report Enhancements, Pagination, and Help Tour › should run report, show paginated data, and download CSV — 3.8s
✅ Report Enhancements, Pagination, and Help Tour › should trigger guidance help tour and navigate steps — 2.1s

reporting.spec.ts

✅ Reporting › should display list of reports — 1.8s
✅ Reporting › should navigate to run report page — 2.6s

scheduler-jobs.spec.ts

✅ Scheduler Jobs bulk run › Run Selected is disabled until a job is checked — 2.9s
✅ Scheduler Jobs bulk run › Select All checks every job, and running confirms then triggers each one — 3.8s
✅ Scheduler Jobs bulk run › declining the confirmation runs nothing — 3.7s

two-factor-authentication.spec.ts

✅ two-step verification › asks for a code and lets the user in once it is accepted — 1.6s
✅ two-step verification › sends the token on every later request — 1.6s
✅ two-step verification › keeps the user on the step when the code is wrong, and says why — 1.4s
✅ two-step verification › accepts a correct code after a wrong one — 1.7s
✅ two-step verification › offers the choice when there is more than one channel — 1.3s
✅ two-step verification › says so when the account has no channel configured — 1.2s
✅ two-step verification › returns to the choice when the code could not be sent — 2.2s
✅ two-step verification › does not let a half-finished session reach the application — 3.1s
✅ two-step verification › backing out returns to the password form — 1.3s
✅ two-step verification › a deployment without a second factor signs in exactly as before — 1.6s

working-capital-loan-actions.spec.ts

✅ Working Capital loan delinquency, breach and near-breach actions, and originators › shows delinquency action history and submits a new one — 4.8s
✅ Working Capital loan delinquency, breach and near-breach actions, and originators › shows breach action history and submits a new one — 5.3s
✅ Working Capital loan delinquency, breach and near-breach actions, and originators › shows near-breach action history and submits a new one — 4.6s
✅ Working Capital loan delinquency, breach and near-breach actions, and originators › attaches and detaches a loan originator — 4.4s
✅ Working Capital loan delinquency, breach and near-breach actions, and originators › adds a new charge and waives an existing one — 4.6s
✅ Working Capital loan delinquency, breach and near-breach actions, and originators › shows rate-change history, amortization schedule, and delinquency range tags — 3.1s
✅ Working Capital loan delinquency, breach and near-breach actions, and originators › marks the loan as fraud, applies a discount, and changes the payment rate — 5.1s

Slowest 10 — what the shard counts should be tuned against

Test	Spec	Time
Loan product down payment and tranches › the rest interval appears only when the frequency is not the repayment period	`loan-product-down-payment.spec.ts`	14.9s
route authorization › a superuser reaches every sampled route and sees the full navigation	`rbac-route-protection.spec.ts`	12.8s
route authorization › a read-only user gets the lists and not the forms	`rbac-route-protection.spec.ts`	11.1s
route authorization › a single-module user is confined to that module	`rbac-route-protection.spec.ts`	9.3s
route authorization › a user with an empty permission list is refused everywhere and the app still works	`rbac-route-protection.spec.ts`	8.4s
route authorization › a deployment with RBAC turned off behaves as it did before the guard	`rbac-route-protection.spec.ts`	7.1s
empty account tabs offer the matching creation action	`client-empty-account-cta.spec.ts`	7.0s
route authorization › an unauthenticated visitor is asked to sign in, not told they are forbidden	`rbac-route-protection.spec.ts`	6.2s
navigation and routes agree › a hidden menu entry is also refused by URL, and a shown one is not	`rbac-route-protection.spec.ts`	6.0s
route authorization › a session carrying no permissions field is treated as carrying none	`rbac-route-protection.spec.ts`	5.8s

📼 Download the HTML report, videos and traces — see the playwright-report-mocked artifact.

_{Generated by run 34199422251 from 396bd14. The run executed a fork branch, so treat its contents as unverified.}

github-actions · 2026-09-08T07:56:12Z

E2E — real Fineract

🎭 E2E Tests

✅ All green — 77 passed · 0 failed · 0 skipped · 2 flaky, across 23 spec files in 7m 1s.

⚠️ Passed on retry

Green overall, but these needed more than one attempt — the shape a flake takes.

Batch API Operations against Fineract › runs the sample batch scenario — create client, create loan, add and read back a charge — batch-api-operations.spec.ts (1 retry/retries)
Batch API enclosingTransaction semantics against Fineract › rolls back the earlier steps when enclosingTransaction is true and a later step fails — batch-api-operations.spec.ts (1 retry/retries)

By spec file

Spec	✅	Time
backend.setup.ts	3	6.0s
batch-api-operations.spec.ts	5	34.8s
center-servicing.spec.ts	2	18.1s
client-transfer.spec.ts	4	45.3s
deposit-account-servicing.spec.ts	3	26.1s
deposit-product-configuration.spec.ts	3	15.7s
group-membership.spec.ts	3	46.8s
loan-account-actions.spec.ts	3	23.8s
loan-charge-off.spec.ts	2	20.2s
loan-product-accounting.spec.ts	1	35.1s
loan-servicing.spec.ts	2	20.3s
login.spec.ts	4	5.6s
parity-screens.spec.ts	8	44.5s
rbac-backend-restricted-user.spec.ts	7	36.3s
rbac-multi-permission.spec.ts	9	55.6s
full-demo.spec.ts	1	1m 6s
loan-lifecycle.spec.ts	4	2m 7s
loan-schedule-type.spec.ts	3	36.4s
report-parameter-backend.spec.ts	4	23.1s
savings-transaction-correction.spec.ts	1	7.7s
share-account-servicing.spec.ts	2	18.9s
share-product-accounting.spec.ts	1	23.8s
teller-cash-management.spec.ts	2	36.9s

All 77 tests — click to expand

backend.setup.ts

✅ seed backend reference data — 2.0s
✅ seed backend reference data — 2.1s
✅ seed backend reference data — 1.9s

batch-api-operations.spec.ts

✅ Batch API Operations against Fineract › runs the sample batch scenario — create client, create loan, add and read back a charge — 9.8s (retried 1×)
✅ Batch API Operations against Fineract › shows a parse error instead of submitting when the batch input is not valid JSON — 6.5s
✅ Batch API enclosingTransaction semantics against Fineract › rolls back the earlier steps when enclosingTransaction is true and a later step fails — 8.8s (retried 1×)
✅ Batch API enclosingTransaction semantics against Fineract › does not roll back the earlier steps when enclosingTransaction is false and a later step fails — 5.2s
✅ Batch API Operations on a mobile viewport against Fineract › the sample batch scenario is reachable and works by touch at mobile width — 4.7s

center-servicing.spec.ts

✅ Center servicing › a center is activated, staffed and given a group — 12.7s
✅ Center servicing › notes are recorded against the center — 5.4s

client-transfer.spec.ts

✅ Client transfer between offices › a proposed transfer is held until the destination accepts, and then the client moves — 11.9s
✅ Client transfer between offices › a rejected transfer leaves the client on hold, and withdrawing is the way back — 12.0s
✅ Client transfer between offices › a client can be transferred in one step when the user may act for both offices — 10.4s
✅ Client staff assignment › an officer can be assigned and then removed — 11.0s

deposit-account-servicing.spec.ts

✅ Term deposit account servicing › an account is approved, activated and closed before maturity — 11.3s
✅ Term deposit account servicing › a deposit is recorded, listed, and reversed without leaving the list — 9.5s
✅ Term deposit account servicing › an application can be rejected instead of approved — 5.3s

deposit-product-configuration.spec.ts

✅ Deposit product configuration › a fixed deposit product survives being edited — 5.5s
✅ Deposit product configuration › a recurring deposit product can be created at all — 4.2s
✅ Deposit product configuration › a savings product carries its accounting configuration — 6.0s

group-membership.spec.ts

✅ Group membership and lifecycle › a group is activated, staffed, given members and a committee, then emptied — 20.3s
✅ Group membership and lifecycle › notes are recorded against the group and can be removed again — 7.9s
✅ Group membership and lifecycle › an empty group is closed with a reason, and a group with members is refused — 18.7s

loan-account-actions.spec.ts

✅ Loan account lifecycle actions › new action menu items appear only for active loans — 7.5s
✅ Loan account lifecycle actions › undo disbursal shows a confirm dialog and reverts the loan to Approved — 8.0s
✅ Loan account lifecycle actions › write off requires confirmation and moves the loan out of Active status — 8.2s

loan-charge-off.spec.ts

✅ Loan servicing commands › charges a loan off through the UI and reverses it — 10.4s
✅ Loan servicing commands › records a goodwill credit through the shared transaction form — 9.8s

loan-product-accounting.spec.ts

✅ Loan product accounting › a cash-accounting product is configured, round-trips on edit, and posts to the ledger — 35.1s

loan-servicing.spec.ts

✅ Loan servicing: notes and transaction adjustment › notes can be added and removed, with a confirm dialog on delete — 9.4s
✅ Loan servicing: notes and transaction adjustment › a repayment transaction can be viewed and adjusted with a corrected amount — 10.9s

login.spec.ts

✅ Login › login page displays correctly — 1.4s
✅ Login › login form has required fields — 1.4s
✅ Login › submit button is disabled when form is empty — 1.4s
✅ Login › submit button is enabled when form is filled — 1.3s

parity-screens.spec.ts

✅ Screens added for platform parity › a manual journal entry can be read whole and reversed — 6.3s
✅ Screens added for platform parity › an entry that is already reversed is not offered again — 4.4s
✅ Screens added for platform parity › a report definition can be created, edited and deleted; a core one cannot — 5.6s
✅ Screens added for platform parity › a core report opens read-only with only its in-use setting — 4.6s
✅ Screens added for platform parity › a pending loan is approved from the queue, in a batch — 6.6s
✅ Screens added for platform parity › a fixed deposit is listed as a deposit, not as a savings account — 4.8s
✅ Screens added for platform parity › an office has a screen, and it carries its custom fields — 5.6s
✅ Screens added for platform parity › a savings account carries notes, and the note survives a reload — 6.5s

rbac-backend-restricted-user.spec.ts

✅ a genuinely restricted Fineract user › holds exactly the permissions their role was granted — 252ms
✅ a genuinely restricted Fineract user › reaches the screen their permission covers — 5.3s
✅ a genuinely restricted Fineract user › is refused a screen their permission does not cover, by URL and by the backend — 4.7s
✅ a genuinely restricted Fineract user › is refused a write screen they can read the list for, and the write itself — 7.1s
✅ a genuinely restricted Fineract user › is not offered the actions it would be refused for — 3.8s
✅ a genuinely restricted Fineract user › is shown an action it cannot take, disabled and saying what it needs — 6.1s
✅ a genuinely restricted Fineract user › the superuser the rest of the suite uses is unaffected — 9.0s

rbac-multi-permission.spec.ts

✅ a route declaring more than one permission code (OR semantics) › is admitted by either declared code alone — 4.7s
✅ a route declaring more than one permission code (OR semantics) › is admitted by the other declared code alone — 5.0s
✅ a route declaring more than one permission code (OR semantics) › is refused when holding neither declared code, by the router and by the backend — 4.4s
✅ ALL_FUNCTIONS_READ, against the real Fineract permission catalogue › reaches read screens across modules it holds no specific code for — 9.0s
✅ ALL_FUNCTIONS_READ, against the real Fineract permission catalogue › is refused every write screen, and the writes themselves — 7.4s
✅ a restricted session across a real page reload › keeps the same permission boundary after reloading, not just after a fresh login — 9.8s
✅ a second real action-level gate, distinct from loan repayment › is shown the Approve action disabled and naming what it needs, refused by the backend too — 5.0s
✅ Security module writes (users, roles), against the real backend › reaches the list screens but is refused the write screens — 10.0s
✅ Security module writes (users, roles), against the real backend › is refused creating a user and modifying a role, by the backend itself — 282ms

full-demo.spec.ts

✅ Full feature demo recording › walk through loan schedule type, lifecycle, custom fields, collateral, and disbursement — 1m 6s

loan-lifecycle.spec.ts

✅ Loan lifecycle: creation, approval, disbursement › create, approve, and disburse a Cumulative loan — 33.0s
✅ Loan lifecycle: creation, approval, disbursement › create, approve, and disburse a Progressive loan — 34.3s
✅ Loan lifecycle: creation, approval, disbursement › an approved loan can be returned to pending approval — 30.6s
✅ Loan lifecycle: creation, approval, disbursement › the delinquency tab reads a real loan, and the empty data tabs stay hidden — 28.8s

loan-schedule-type.spec.ts

✅ Loan Schedule Type (Cumulative vs Progressive) › loan products list shows a schedule type chip per product — 10.0s
✅ Loan Schedule Type (Cumulative vs Progressive) › create a Progressive loan product end-to-end and verify it round-trips — 15.6s
✅ Loan Schedule Type (Cumulative vs Progressive) › loan creation shows the schedule type badge for a Progressive product — 10.8s

report-parameter-backend.spec.ts

✅ Dynamic report parameters against Fineract › keeps the parameter form available when a report has cascading lookups — 5.4s
✅ Dynamic report parameters against Fineract › changing Office changes the Client Listing row set — 6.3s
✅ Cascading report parameters against Fineract › sends the parent value to the child lookup and clears the child when it changes — 7.3s
✅ Chart reports against Fineract › renders a chart report as a chart rather than a table — 4.2s

savings-transaction-correction.spec.ts

✅ Savings transaction correction › a deposit is reversed and a hold is released — 7.7s

share-account-servicing.spec.ts

✅ Share account servicing › an account is approved, activated, traded and closed — 12.3s
✅ Share account servicing › an application can be rejected — 6.5s

share-product-accounting.spec.ts

✅ Share product accounting › a share product is mapped to equity and round-trips on edit — 23.8s

teller-cash-management.spec.ts

✅ Teller cash management › a cashier is listed, receives an allocation, and settles cash back — 25.2s
✅ Teller cash management › settling more than the cashier holds is refused and the form stays usable — 11.7s

Slowest 10 — what the shard counts should be tuned against

Test	Spec	Time
Full feature demo recording › walk through loan schedule type, lifecycle, custom fields, collateral, and disbursement	`full-demo.spec.ts`	1m 6s
Loan product accounting › a cash-accounting product is configured, round-trips on edit, and posts to the ledger	`loan-product-accounting.spec.ts`	35.1s
Loan lifecycle: creation, approval, disbursement › create, approve, and disburse a Progressive loan	`loan-lifecycle.spec.ts`	34.3s
Loan lifecycle: creation, approval, disbursement › create, approve, and disburse a Cumulative loan	`loan-lifecycle.spec.ts`	33.0s
Loan lifecycle: creation, approval, disbursement › an approved loan can be returned to pending approval	`loan-lifecycle.spec.ts`	30.6s
Loan lifecycle: creation, approval, disbursement › the delinquency tab reads a real loan, and the empty data tabs stay hidden	`loan-lifecycle.spec.ts`	28.8s
Teller cash management › a cashier is listed, receives an allocation, and settles cash back	`teller-cash-management.spec.ts`	25.2s
Share product accounting › a share product is mapped to equity and round-trips on edit	`share-product-accounting.spec.ts`	23.8s
Group membership and lifecycle › a group is activated, staffed, given members and a committee, then emptied	`group-membership.spec.ts`	20.3s
Group membership and lifecycle › an empty group is closed with a reason, and a group with members is refused	`group-membership.spec.ts`	18.7s

📼 Download the HTML report, videos and traces — see the playwright-report-backend artifact.

_{Generated by run 34199422251 from 396bd14. The run executed a fork branch, so treat its contents as unverified.}

Aman-Mittal

I think this is the appropirate fix, you can remove move the advanced ai search
You should extend its capabilities and create a single client search section with pagination

fix(i18n): rename advanced client search

396bd14

The page exposes one client-scoped free-text query, so align its navigation label and title with the capability it actually provides. Signed-off-by: FenjuFu <92919259+FenjuFu@users.noreply.github.com>

Aman-Mittal requested changes Sep 8, 2026

View reviewed changes

Navigation Menu

Uh oh!

fix(i18n): rename advanced client search - #533

fix(i18n): rename advanced client search#533
FenjuFu wants to merge 1 commit into
apache:mainfrom
FenjuFu:fix/client-search-label

FenjuFu commented Sep 8, 2026

Uh oh!

github-actions Bot commented Sep 8, 2026

Uh oh!

github-actions Bot commented Sep 8, 2026

Uh oh!

Aman-Mittal left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

FenjuFu commented Sep 8, 2026

What and why

Verification

Screenshots

Checklist

Uh oh!

github-actions Bot commented Sep 8, 2026

E2E — mocked backend

🎭 E2E Tests

By spec file

Uh oh!

github-actions Bot commented Sep 8, 2026

E2E — real Fineract

🎭 E2E Tests

⚠️ Passed on retry

By spec file

Uh oh!

Aman-Mittal left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants