fix(paginator): reflow controls on mobile - #500
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The mobile grid track sizing currently gives the flexible space to the select instead of the label, which can still allow the label to be squeezed/wrapped into fragments at narrow widths.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR improves the shared app-paginator mobile UX by introducing a responsive layout at the app’s mobile breakpoint so the “items per page” controls don’t become unreadable on narrow screens (affecting every list view that uses the shared data table paginator).
Changes:
- Adds a
@media (max-width: 768px)style block to switch the paginator from a single-row flex layout to a two-row grid layout on phones. - Adjusts spacing and sizing on mobile (smaller gaps, removes select
min-width, removes range-label margins) to prevent overflow/squeezing.
File summaries
| File | Description |
|---|---|
| src/app/shared/components/paginator/paginator.component.ts | Adds a mobile breakpoint layout for paginator controls to avoid label squeezing and reflow navigation onto a second row. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ce78e38 to
ed663af
Compare
|
@Copilot review |
E2E — mocked backend🎭 E2E Tests✅ All green — 347 passed · 0 failed · 1 skipped, across 28 spec files in 6m 42s. By spec file
All 348 tests — click to expand
Slowest 10 — what the shard counts should be tuned against
📼 Download the HTML report, videos and traces — see the Generated by run 34045899606 from |
E2E — real Fineract🎭 E2E Tests✅ All green — 77 passed · 0 failed · 0 skipped, across 23 spec files in 7m 5s. By spec file
All 77 tests — click to expand
Slowest 10 — what the shard counts should be tuned against
📼 Download the HTML report, videos and traces — see the Generated by run 34045899606 from |
|
@Copilot review |
|
Addressed the review feedback in e8a5c78: the mobile grid now gives the translated label an intrinsic max-content track, keeps it on one line, and leaves the select as the flexible track. The focused paginator suite passes (12 tests), with formatting, lint, and diff checks clean. @Copilot review |
761d44e to
92dbb12
Compare
92dbb12 to
d7f9a5f
Compare
|
Rebased onto upstream main and resolved the e2e/mobile-shell.spec.ts conflict while retaining both dashboard column-stacking and paginator-label coverage. Pushed d7f9a5f; git diff --check passes. @Copilot review |
What and why
The shared paginator squeezes its label, page-size selector, range, and four navigation buttons into one non-wrapping row on phones. It now uses a two-row grid at the shared mobile breakpoint: page-size controls occupy the first row, while the range and navigation controls occupy the second.
Closes #490
Validation
npm test -- --watch=false --include=src/app/shared/components/paginator/paginator.component.test.ts— 12 passedpaginator.component.ts— passedgit diff --check— passedChecklist