fix: ignore structural tags when lifting expression coverage - #5471
Draft
sunchao wants to merge 1 commit into
Draft
fix: ignore structural tags when lifting expression coverage#5471sunchao wants to merge 1 commit into
sunchao wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No issue is automatically closed. This is a standalone follow-up to the existing structural-expression tag filtering.
Rationale for this change
Expression rewrites lift coverage tags from a rebuilt tree to its original owner. The lift currently includes tags on structural nodes, so stale tags on a shared literal can be copied onto an alias and appear as legitimate native or codegen-dispatch coverage in extended explain output.
What changes are included in this PR?
CometExplainInfo.collectExprTagValuesto filter structural nodes before lifting either coverage-tag category.TrueLiteralregression through decimal promotion. It checks that realcheckoverflowcoverage survives while planted native and dispatch tags do not reach the alias or unrelated plan.Only
QueryPlanSerdeand the existingCometCodegenSuitechange; query execution semantics are unchanged.How are these changes tested?
Draft: JVM validation is blocked, so no passing JVM test result is claimed.
5baa6b03.git diff --checkpassed.Intended focused check:
The expanded singleton regression and existing expression-coverage tests still need to be run before this draft is ready to merge.