Skip to content

Count rows produced instead of getRow() in printRecords(ResultSet)#627

Merged
garydgregory merged 1 commit into
apache:masterfrom
rootvector2:resultset-maxrows-produced
Jul 21, 2026
Merged

Count rows produced instead of getRow() in printRecords(ResultSet)#627
garydgregory merged 1 commit into
apache:masterfrom
rootvector2:resultset-maxrows-produced

Conversation

@rootvector2

Copy link
Copy Markdown
Contributor

printRecords(ResultSet) caps maxRows with resultSet.getRow(), the absolute cursor position. JDBC makes getRow() optional for TYPE_FORWARD_ONLY result sets and a driver can return 0 there, so useRow(0) stays true and the cap is silently skipped while the whole result set streams out; it is also off for a pre-positioned result set. Count the rows produced by this call instead, matching the parser's row-produced counter from CSV-327.

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

@garydgregory garydgregory changed the title count rows produced instead of getRow() in printRecords(ResultSet) Count rows produced instead of getRow() in printRecords(ResultSet) Jul 21, 2026
@garydgregory
garydgregory merged commit 2102200 into apache:master Jul 21, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants