fix: use utf-8 in CI smoke server script#843
Merged
Merged
Conversation
skrawcz
approved these changes
Jul 23, 2026
skrawcz
approved these changes
Jul 23, 2026
skrawcz
enabled auto-merge (squash)
July 23, 2026 14:44
Contributor
Author
|
Thank you for the review and merge, I appreciate it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
scripts/ci_smoke_server.pywrites and reads text artifacts without specifying an encoding. On Windows or other non-UTF-8 default locales, the generated app script or captured server log can become locale-dependent even though the script content is text.Before / after
Before:
Path.read_text()without an explicit encoding.Path.write_text()without an explicit encoding.After:
encoding="utf-8".Verification
python -m py_compile scripts/ci_smoke_server.py