Skip to content

fix: use utf-8 in CI smoke server script#843

Merged
skrawcz merged 1 commit into
apache:mainfrom
Ghraven:fix/ci-smoke-server-utf8
Jul 23, 2026
Merged

fix: use utf-8 in CI smoke server script#843
skrawcz merged 1 commit into
apache:mainfrom
Ghraven:fix/ci-smoke-server-utf8

Conversation

@Ghraven

@Ghraven Ghraven commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Problem

scripts/ci_smoke_server.py writes and reads text artifacts without specifying an encoding. On Windows or other non-UTF-8 default locales, the generated app script or captured server log can become locale-dependent even though the script content is text.

Before / after

Before:

  • The smoke server log was opened with the platform default text encoding.
  • The failure log dump used Path.read_text() without an explicit encoding.
  • The generated Burr app script used Path.write_text() without an explicit encoding.

After:

  • All three text boundaries use encoding="utf-8".
  • Binary/network handling is unchanged.

Verification

  • python -m py_compile scripts/ci_smoke_server.py

@github-actions github-actions Bot added the area/ci Workflows, build, release scripts label Jul 22, 2026
@skrawcz
skrawcz enabled auto-merge (squash) July 23, 2026 14:44
@skrawcz
skrawcz merged commit f9b9fd6 into apache:main Jul 23, 2026
29 checks passed
@Ghraven

Ghraven commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Thank you for the review and merge, I appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci Workflows, build, release scripts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants