fix(core): wipe() with no arguments should clear all state instead of raising#840
Open
eeshsaxena wants to merge 1 commit into
Open
fix(core): wipe() with no arguments should clear all state instead of raising#840eeshsaxena wants to merge 1 commit into
eeshsaxena wants to merge 1 commit into
Conversation
State.wipe() documents that passing neither delete nor keep deletes everything, but with both None it fell through to a 'key not in keep' check with keep=None and raised TypeError. Handle the no-args case explicitly (delete every key) and add a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
State.wipe()with no arguments should clear all state, but currently raisesTypeError.The docstring says:
But when both
deleteandkeepareNone, the method fell through to thekeepbranch and evaluatedkey not in keepwithkeep=None:The
delete=andkeep=forms were covered by tests, but the documented no-args form was not, so this went unnoticed.Fix
Handle the three cases explicitly in
wipe():delete=[...]-> delete those keyskeep=[...]-> delete everything not keptVerification
Added
test_state_wipe_allalongside the existing wipe tests.tests/core/test_state.pypasses (27 passed).