Element: Remove unused & deprecated node_subst methods#2154
Element: Remove unused & deprecated node_subst methods#2154nathanwilliams-ct wants to merge 1 commit into
Conversation
These deprecation notices were introduced into the codebase 6 years ago (April 16th, 2020 5:56 PM) There have been many Buildstream versions since then, a search in the Buildstream codebase shows they are unused, so it's about time they are removed.
|
Unfortunately, this is part of the public plugin API where we guarantee stability across stable releases. We failed to remove it before 2.0. And some plugins in buildstream-plugins-community are even still using it, should probably fix that. |
|
So this PR is a candidate for 3.0 assuming we sort the buildstream community plugins for it. Do you know if there's an issue to track this? |
|
I don't think we have an issue in https://gitlab.com/BuildStream/buildstream-plugins-community/ for this, probably makes sense to open one. We also don't have a milestone or label for BuildStream 3.0, not sure whether we should create one without more specific plans. |
|
Might be worth creating a label at minimum, so it's easy to find these sorts of issues/ PRs for if/when a 3.0 is planned. |
3 participants
These deprecation notices were introduced into the codebase 6 years ago (April 16th, 2020 5:56 PM) e5ed02d
There have been many Buildstream versions since then, a search in the Buildstream codebase shows they are unused, so it's about time they are removed.