bench: cover small run-index selections and full scans - #10848
Draft
sunchao wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Which issue does this PR close?
Related to #10846; this benchmark-only PR does not close the performance issue.
Rationale for this change
RunEndBuffer::get_physical_indicescan keep visiting physical runs after it has mapped all requested logical indices. Small selections from large backing buffers need dedicated coverage, alongside full-scan controls, before changing the iteration strategy.What changes were proposed in this PR?
What changes are included in this PR?
Add a Criterion benchmark for two-element prefix selections, two-element selections from a sliced buffer, and all-index selections. Each case runs with 1,024 and 1,048,576 physical runs. Input construction stays outside the timed loop. This separate benchmark PR follows the contributor guide's performance workflow.
Are there any user-facing changes?
None. This PR adds benchmarks only.
How was this PR tested?
Are these changes tested?
900ec3ee38276ab651e210c4a85b38f8a8a61bcf, with this benchmark added.AI assistance: Codex generated the benchmark and PR text and ran the stated local checks. This does not claim a separate human review.