Make PageIndex::new public, add doc example of building a synthetic PageIndex - #10825
Closed
alamb wants to merge 2 commits into
Closed
Make PageIndex::new public, add doc example of building a synthetic PageIndex#10825alamb wants to merge 2 commits into
PageIndex::new public, add doc example of building a synthetic PageIndex#10825alamb wants to merge 2 commits into
Conversation
Contributor
|
Perhaps I could interest you in a builder 😅 #10784 |
Contributor
Author
Yes! I was just reviewing this PR and the signature for new was ugly and I had just decided I was going to have claude whip up a builder. Even better that you have one (you are already ahead!). Let's go with that |
Contributor
|
I |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
PageIndexcannot be constructed outside the crate #10824.Rationale for this change
#10719 introduced the
PageIndexstruct but its constructor ispub(crate), so external code can no longer assembleColumnIndexMetaData/OffsetIndexMetaDatavalues (whose builders are still public) into aParquetMetaData. DataFusion relies on this to construct synthetic metadata in tests that exercise page-level statistics handling (see apache/datafusion#24366).What changes are included in this PR?
PageIndex::newpuband document its argumentsPageIndexand attach it to aParquetMetaDataviaParquetMetaDataBuilder::set_page_index, modeled on the DataFusion test code that needs this APIAre these changes tested?
Yes, by the new doc example.
Are there any user-facing changes?
PageIndex::newis now part of the public API. No breaking changes.