fix(ingress-controller): align listener port matching default - #1002
Open
kayx23 wants to merge 1 commit into
Open
fix(ingress-controller): align listener port matching default#1002kayx23 wants to merge 1 commit into
kayx23 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
listenerPortMatchMode: autotooff, matching the controller 2.2.0 safety defaultoffand bump the chart to 1.3.1autoorexplicitautooverrideWhy
APISIX Ingress Controller changed its omitted-field default to
offin apache/apisix-ingress-controller#2804 after review reproduced a common mismatch: a Gateway listener declares port 80, Kubernetes maps Service port 80 to APISIX port 9080, and an injectedserver_port == 80predicate causes the route to miss.Chart 1.3.0 still explicitly renders
auto, so Helm users never receive the controller's safer fallback. This PR aligns the dedicated chart with the released controller contract.Users who intentionally rely on listener-port matching can preserve the old chart behavior with:
The APISIX umbrella chart still pins controller chart 1.3.0. Its dependency should be updated after 1.3.1 is published; it cannot safely reference the unpublished remote chart in this PR.
Validation
bash -n test/ingress-controller-config-defaults.shbash test/ingress-controller-config-defaults.shauto, andexplicithelm templaterendershelm package charts/apisix-ingress-controllerhelm-docs@v1.11.0regeneration is idempotentgit diff --checkCloses #1001.
Related: api7/api7-ingress-controller#462, #997.