Support dynamic metric name prefixes in the metrics registry check - #71276
Open
aeroyorch wants to merge 1 commit into
Open
Support dynamic metric name prefixes in the metrics registry check#71276aeroyorch wants to merge 1 commit into
aeroyorch wants to merge 1 commit into
Conversation
aeroyorch
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl and
potiuk
as code owners
August 7, 2026 09:49
boring-cyborg
Bot
added
area:dev-tools
backport-to-v3-3-test
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The registry check turns each metric name into a template and looks it up in
metrics_template.yaml. When the variable comes first there's no static prefix to matchon, so the metric is flagged as missing even though every expansion is registered.
Those names now match on their static suffix, which must start with a dot so it only
aligns at segment boundaries. Nothing else changes.
Related to #69001 and #69007
Was generative AI tooling used to co-author this PR?
Claude Opus 5 for code planning and testing.