Skip to content

Support PLY files with additional elements (e.g., SHARP camera data) #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ztffn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support PLY files with additional elements (e.g., SHARP camera data) #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 21 additions & 9 deletions main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,21 +493,33 @@ function createWorker(self) {
ushort: "getUint16",
uchar: "getUint8",
};
for (let prop of header
.slice(0, header_end_index)
.split("\n")
.filter((k) => k.startsWith("property "))) {
const [p, type, name] = prop.split(" ");
const arrayType = TYPE_MAP[type] || "getInt8";
types[name] = arrayType;
offsets[name] = row_offset;
row_offset += parseInt(arrayType.replace(/[^\d]/g, "")) / 8;
// Only process properties for vertex elements (skip camera data)
let inVertexElement = false;
for (let line of header.slice(0, header_end_index).split("\n")) {
if (line.startsWith("element vertex")) {
inVertexElement = true;
continue;
}
if (line.startsWith("element ")) {
inVertexElement = false;
continue;
}
if (line.startsWith("property ") && inVertexElement) {
const [p, type, name] = line.split(" ");
const arrayType = TYPE_MAP[type] || "getInt8";
types[name] = arrayType;
offsets[name] = row_offset;
row_offset += parseInt(arrayType.replace(/[^\d]/g, "")) / 8;
}
}
console.log("Bytes per row", row_offset, types, offsets);

// Calculate vertex data size and create DataView only for vertex data
const vertexDataSize = vertexCount * row_offset;
let dataView = new DataView(
inputBuffer,
header_end_index + header_end.length,
vertexDataSize
);
let row = 0;
const attrs = new Proxy(
Expand Down