Support per-mode Merlin file configurations - #19
Draft
anmonteiro wants to merge 14 commits into
Draft
Conversation
This was referenced Aug 1, 2026
anmonteiro
force-pushed
the
anmonteiro/editor-mode-prototype
branch
2 times, most recently
from
August 19, 2026 20:33
6a4360c to
b2566db
Compare
anmonteiro
force-pushed
the
anmonteiro/editor-mode-prototype
branch
from
August 24, 2026 03:28
eb042b9 to
efe8bb8
Compare
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Inline the two Common.Decode helpers that became single-use after ocaml#16322. Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
) Support qualified module references in fields such as `(per_module ...)` when using `(include_subdirs qualified)`, gated on Dune language 3.25. Depends on ocaml#16322. Fixes ocaml#15578. --------- Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Fix the opening description in the nested virtual module regression test introduced in ocaml#15633. Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Remove `Module_name.Per_item` now that all callers use `Module_reference.Per_item` after ocaml#15633. Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Suggest dotted qualified module references when slash-separated source paths are used. Depends on ocaml#15633. Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
…ml#16336) Centralize validation of qualified module references in `Module_reference`, allowing its location and qualification helpers to remain private. Split out of ocaml#16214. Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Add regression coverage for module artifact pforms on Melange-only libraries. The test records the current failures; fixes are intentionally left for follow-up work. Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Persist compilation mode and source kind for each Merlin configuration, and expose typed plural file lookup. Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Search later stanza files and parent directories before reporting the first incompatible Merlin configuration. Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Add an additive configuration-server request that returns every applicable mode with tagged metadata and errors. Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Exercise stanza selection, mode-specific directives, source metadata, counterpart lookup, exact matching, and fallback matching. Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
anmonteiro
force-pushed
the
anmonteiro/editor-mode-prototype
branch
from
September 6, 2026 01:02
efe8bb8 to
a712eb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate and expose every effective library Merlin configuration through an additive tagged protocol request while preserving legacy singular behavior.
Related to anmonteiro/merlin#2 and anmonteiro/ocaml-lsp#2.