[devices] public key operations

[capcom6]

Greptile Summary

This PR adds E2E public-key support to device registration and update flows: new publicKey / keyVersion fields propagate through the domain model, GORM model, repository update, handler, DTO converter, and OpenAPI docs. It also resizes the phone_number column from 128 to 512 characters, moves device error sentinel variables from repository.go to errors.go, cleans up the ErrInvalidUser reference that was dropped, and adds a lint-suppression comment in the FCM client.

• E2E fields added end-to-end: migration, GORM model, domain struct, repository Update map, handler PATCH/POST, DTO converter, and OpenAPI Device schema are all updated consistently.
• Phone-number column widened: the SQL migration extends message_recipients.phone_number to varchar(512), matching the updated OpenAPI maxLength: 512 constraint.
• Error cleanup: ErrInvalidUser is removed from both errors.go and the 3rdparty.go error handler; the remaining three device errors are reformatted from fallthrough chains to a single comma-separated errors.Is expression.

Confidence Score: 4/5

• Safe to merge with caveats — the E2E validation gaps flagged in earlier rounds remain unresolved, but they do not introduce new failure modes beyond what already existed before this PR.
• The core plumbing — migration, GORM model, repository, handler, converter, and OpenAPI docs — is internally consistent and the column-widening change is straightforward. The outstanding concerns from prior review rounds (no E2E pair validation on Insert, no sentinel error for inconsistent pairs, empty-string public key stored rather than coerced to NULL) are still present in the codebase and not addressed by this iteration, meaning a device can reach the DB with a partially-configured E2E state through the registration path.
• internal/sms-gateway/modules/devices/service.go (Insert still lacks E2E consistency validation) and internal/sms-gateway/handlers/mobile.go (postDevice creates a user before validating device fields).

Important Files Changed

Filename	Overview
internal/sms-gateway/modules/devices/repository.go	Error sentinels moved to errors.go; public_key / key_version update logic added with independent nil-checks (already flagged in prior rounds). Pointer passed directly for public_key vs dereferenced-and-re-pointed for push_token.
internal/sms-gateway/handlers/mobile.go	Correctly wires PublicKey/KeyVersion from request to domain struct for both POST and PATCH device. ErrInconsistentE2E (if it were ever returned) would still surface as a 500 — flagged in prior rounds and still unresolved.
internal/sms-gateway/models/migrations/mysql/20260728000000_add_device_e2e_keys.sql	Adds public_key (TEXT NULL) and key_version (INT NULL DEFAULT NULL) correctly. Widens phone_number to varchar(512). Missing trailing newline (noted previously). The cosmetic --- separator between Up and Down sections is harmless.
internal/sms-gateway/modules/devices/domain.go	Adds PublicKey/*string and KeyVersion/*int to DeviceUpdate with clear doc-comments. References to the unimplemented ErrInconsistentE2E removed from doc-comments in this revision.
internal/sms-gateway/modules/devices/errors.go	ErrInvalidUser removed; ErrNotFound / ErrInvalidFilter / ErrMoreThanOne kept and moved here from repository.go. Clean refactor.
internal/sms-gateway/modules/devices/models.go	PublicKey *string and KeyVersion *int added to DeviceModel with gorm:"default:null", which is consistent with the SQL migration using DEFAULT NULL. toDomain and newDeviceModel correctly propagate both fields.
internal/sms-gateway/handlers/converters/devices.go	VersionedPublicKey embedded struct correctly populated from domain Device. Test coverage added in devices_test.go.
internal/sms-gateway/handlers/messages/3rdparty.go	ErrInvalidUser case removed (error no longer exists anywhere); fallthrough chains replaced with comma-separated errors.Is — purely cosmetic and correct.
internal/sms-gateway/modules/push/fcm/client.go	Only change is adding //nolint:staticcheck comment acknowledging a planned migration away from FCM token to FID. No logic changes.

Sequence Diagram

sequenceDiagram
    participant Client as Mobile Client
    participant MH as mobileHandler
    participant AuthSvc as auth.Service
    participant DevSvc as devices.Service
    participant Repo as devices.Repository
    participant DB as MySQL

    Note over Client,DB: Device Registration (POST /mobile/v1/device)
    Client->>MH: "POST {name, pushToken, publicKey, keyVersion}"
    MH->>MH: "BodyParserValidator (validates keyVersion min=1)"
    MH->>AuthSvc: "RegisterDevice(userID, DeviceInfo{PublicKey, KeyVersion})"
    AuthSvc->>DevSvc: Insert(ctx, userID, DeviceInfo)
    DevSvc->>Repo: Insert(ctx, DeviceInput)
    Repo->>DB: INSERT devices (public_key, key_version, ...)
    DB-->>Repo: device row
    Repo-->>DevSvc: "*Device"
    DevSvc-->>AuthSvc: "*Device"
    AuthSvc-->>MH: "*Device"
    MH-->>Client: "201 {id, token, login, password}"

    Note over Client,DB: Device Update (PATCH /mobile/v1/device)
    Client->>MH: "PATCH {id, pushToken, publicKey, keyVersion}"
    MH->>MH: BodyParserValidator
    MH->>DevSvc: "Update(ctx, id, DeviceUpdate{PublicKey, KeyVersion})"
    DevSvc->>Repo: Update(ctx, id, DeviceUpdate)
    Repo->>Repo: build map[string]any (nil-guarded per field)
    Repo->>DB: "UPDATE devices SET public_key=?, key_version=? WHERE id=?"
    DB-->>Repo: ok
    Repo-->>DevSvc: nil
    DevSvc->>DevSvc: cache.DeleteByID(id)
    DevSvc-->>MH: nil
    MH-->>Client: 204

    Note over Client,DB: List Devices (GET /3rdparty/v1/devices)
    Client->>MH: GET /3rdparty/v1/devices
    MH->>DevSvc: Select(ctx, userID)
    DevSvc->>Repo: Select(ctx, filters)
    DB-->>Repo: []DeviceModel (with public_key, key_version)
    Repo-->>DevSvc: []Device
    DevSvc-->>MH: []Device
    MH->>MH: "DeviceToDTO → smsgateway.Device{VersionedPublicKey}"
    MH-->>Client: "200 [{..., publicKey, keyVersion}]"

Loading

_{Reviews (28): Last reviewed commit: "[lint] ignore FCM Fid migration" | Re-trigger Greptile}

[github-actions]

🤖 Pull request artifacts

Platform	File
🐳 Docker	GitHub Container Registry
🍎 Darwin arm64	server_Darwin_arm64.tar.gz
🍎 Darwin x86_64	server_Darwin_x86_64.tar.gz
🐧 Linux arm64	server_Linux_arm64.tar.gz
🐧 Linux i386	server_Linux_i386.tar.gz
🐧 Linux x86_64	server_Linux_x86_64.tar.gz
🪟 Windows arm64	server_Windows_arm64.zip
🪟 Windows i386	server_Windows_i386.zip
🪟 Windows x86_64	server_Windows_x86_64.zip

[greptile-apps]

Want your agent to iterate on Greptile's feedback? Try greploops.

[capcom6]

@greptile review