Add option to search through session panes

[paluh]

Great plugin! Thanks a lot for writing it!

I'm not sure if you would like to merge this addition - it is a breaking change (I've changed all_panes boolean option to panes which is a choice) which I have not discussed ;-)

[andersevenrud]

Thanks for using my plugin and for the contribution!

I really like the idea of this, but I think maybe this could be introduced without any immediate breaking changes and instead provide a migration path.

So maybe keep the all_panes option, but emit a warning if it's been set to true and suggest using the option introduced here ?

[andersevenrud]

Linter seems to have tripped :)

[paluh]

Linter seems to have tripped :)

Oh, I'm really sorry about that. I have to setup lua linting and fix that for sure.

So maybe keep the all_panes option, but emit a warning if it's been set to true and suggest using the option introduced here ?

We can try to use both options but I'm not sure if this won't be more confusing (the interaction between different setups etc.)?

Or we can tag the current version and prepare next proper release? Then we can bump the minor version with appropriate change log and provide migration error messages?

We can add to the release some additional changes:

• I've already made trigger_characters_* optional (I'm using keyword_length myself)
• I'm thinking that limiting the result number or the actual search space per pane could be another useful addition - what do you think?

P.S.
Unfortunately I'm not able to to hack on these fixes probably during the week and I will do them during next weekend I think ;-)

[andersevenrud]

Oh, I'm really sorry about that. I have to setup lua linting and fix that for sure.

No worries! I probably should add a contribution guide here as there's linting on the commit messages as well which will fail after the code linting. This repo uses https://www.conventionalcommits.org/en/v1.0.0/

We can try to use both options but I'm not sure if this won't be more confusing (the interaction between different setups etc.)?

I feel like if the documentation of all_panes was removed and if enabled was made to emit a warning message, that would suffice. If everyone used a package manager that warned about changes like this by scanning the commit messages I would just go strait for it, but sadly that's not the case, hehe. I might be overthinking this as well 🤷‍♂️

I've already made trigger_characters_* optional (I'm using keyword_length myself)

I'll have to look into that.

I'm thinking that limiting the result number or the actual search space per pane could be another useful addition - what do you think?

What would be the benefit of this ?

Unfortunately I'm not able to to hack on these fixes probably during the week and I will do them during next weekend I think

Take your time!