refactor(value): migrate Value::Array to Array storage abstraction - #65
Open
anakrish wants to merge 1 commit into
Open
refactor(value): migrate Value::Array to Array storage abstraction#65anakrish wants to merge 1 commit into
anakrish wants to merge 1 commit into
Conversation
anakrish
force-pushed
the
storage-abstraction-array-foundation
branch
from
June 4, 2026 20:30
872e582 to
05a1592
Compare
anakrish
force-pushed
the
storage-abstraction-array-migration
branch
from
June 4, 2026 20:34
2785962 to
05d332e
Compare
Swap Value::Array payload storage from Vec<Value> to the value::Array abstraction while preserving Vec<Value> conversion compatibility. Update as_array/as_array_mut to expose Array and delegate array Value construction through Array::into_value. Delegate RVM binary serialization through Array-aware references and deserialize array payloads into Array. Rewrite IterationState::Array around ArrayCursor so setup_next_iteration self-advances and advance() is a no-op, with Rc copy-on-write snapshot coverage. Migrate array builtin, interpreter, RVM, metadata, schema test, binding test, and language construction sites to the Array API. Judgment call: kept Value::from(Vec<Value>) and a generic internal from_array helper for existing compatibility while storing Array internally. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
anakrish
force-pushed
the
storage-abstraction-array-foundation
branch
from
June 6, 2026 12:58
05a1592 to
81ae161
Compare
anakrish
force-pushed
the
storage-abstraction-array-migration
branch
from
June 6, 2026 12:58
05d332e to
121583f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Judgment calls
Validation