refactor(value): migrate Value::Set to Set storage abstraction - #64
Open
anakrish wants to merge 1 commit into
Open
refactor(value): migrate Value::Set to Set storage abstraction#64anakrish wants to merge 1 commit into
anakrish wants to merge 1 commit into
Conversation
Swap Value::Set from Rc<BTreeSet<Value>> to Rc<Set> and migrate Set call sites across builtins, languages, RVM, metadata, serialization, and tests to the curated Set API. Rewrite RVM IterationState::Set around SetCursor so set iteration resumes through the storage abstraction and remains snapshot-independent via Rc copy-on-write. Remove the old current_item resume plumbing from comprehension and loop paths. Keep Value::as_set/as_set_mut names while returning &Set/&mut Set, and use Set::intersection/union/difference plus Set::into_value for set algebra. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
anakrish
force-pushed
the
storage-abstraction-set-foundation
branch
from
June 6, 2026 12:58
39fff42 to
923da90
Compare
anakrish
force-pushed
the
storage-abstraction-set-migration-v2
branch
from
June 6, 2026 12:58
a6e6bc2 to
70d0e98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Value::Setto storeRc<value::Set>and keepas_set/as_set_muton the curated storage API.IterationState::SetaroundSetCursor, removing the oldcurrent_itemresume plumbing while preserving snapshot independence viaRccopy-on-write.Setoperations.Stacked on #60 (
storage-abstraction-set-foundation).