Fix/academy review findings - #17
Merged
Merged
Conversation
Every slide's root carries dir={dir}, which is rtl in Hebrew, and the code
panels inside it inherited it. The bidi algorithm then resolved each line's
trailing neutrals against an RTL paragraph and moved them to the front, so
def test_system_prompt_includes_persona():
rendered as
:()def test_system_prompt_includes_persona
Every deck was affected, because the panels are copy-shared between the ten
artifacts. Code reads left-to-right whatever the prose around it does, so
each panel now says so itself: direction: 'ltr' plus textAlign: 'left',
because direction alone leaves text-align: start, which an ancestor's
explicit textAlign: 'right' still wins over — and several slides set exactly
that on the column holding the panel.
246 declarations across 98 slide components in all ten decks.
tests/unit/lectureDecks.spec.ts gains three cases, in the file that already
guards the copy-shared stage logic: one that there are panels to find at all,
so a regex that stops matching cannot turn the others green, and one each for
direction and alignment. Checked by mutation — removing a single declaration
from one slide in one deck fails the suite.
Verified in a browser as well as in the source: all 323 slides in all ten
decks were loaded with ?lang=he and every element that introduces a monospace
family was asserted to compute direction: ltr. That sweep is what caught the
last ten, which sit in single-line style objects that Prettier writes without
a trailing comma — the first pass required one and skipped them, and the
first version of the test had the same blind spot.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.