Pretty print top level errors - #553
Open
selvmaya wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are already
Displayimplementations for the top levelcrate::Errorenum, but when running gitu it bubbles them up all the way to main, which makes rust debug print theResult: https://doc.rust-lang.org/src/std/process.rs.html#2684This PR merely wraps
main, pretty prints the error if one occurs, and explicitly returns anExitCode(success/failure) depending on the result, instead of using the genericTerminationimplementation forResult<T: Termination, E: Debug>.I assume this is probably closer to what was intended with the explicit
Displayimplementation ofcrate::Error.