Skip to content

feat: open all external links in a new tab - #226

Open
onerandomusername wants to merge 1 commit into
allhandsactive:masterfrom
onerandomusername:feat/external-links-new-tab
Open

feat: open all external links in a new tab#226
onerandomusername wants to merge 1 commit into
allhandsactive:masterfrom
onerandomusername:feat/external-links-new-tab

Conversation

@onerandomusername

Copy link
Copy Markdown
Collaborator

closes #32

@artlogic artlogic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a supported plugin for github pages: https://pages.github.com/versions.json

@onerandomusername

Copy link
Copy Markdown
Collaborator Author

This is not a supported plugin for github pages: https://pages.github.com/versions.json

Hm... We can solve that by updating our GitHub pages build configuration to use GitHub actions rather than the legacy system.

@artlogic

Copy link
Copy Markdown
Contributor

This is not a supported plugin for github pages: https://pages.github.com/versions.json

Hm... We can solve that by updating our GitHub pages build configuration to use GitHub actions rather than the legacy system.

Can you provide an example of how this is done?

@onerandomusername

Copy link
Copy Markdown
Collaborator Author

https://github.com/actions/upload-pages-artifact

This would be resolved as a part of #230

@JLDohm

JLDohm commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

@onerandomusername Can you give me an update on this? The simplest solution would be if the plugin was now supported. Otherwise, we need to update the action(s) that compile the site?

@onerandomusername

Copy link
Copy Markdown
Collaborator Author

@onerandomusername Can you give me an update on this? The simplest solution would be if the plugin was now supported. Otherwise, we need to update the action(s) that compile the site?

correct. because the plugin isn't supported, we can build the site ourself in a workflow. https://docs.github.com/en/pages/getting-started-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site#publishing-with-a-custom-github-actions-workflow

this has the added advantage that we control the entire environment from start to finish, and can make it match what we have on our developer machines, rather than the black box that is the gh pages in-built building.

@JLDohm

JLDohm commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Would you like to create a new issue to create the workflow for publishing the site using Actions, and then we will be able to proceed here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggestion: Outside links open in a new window

3 participants