Skip to content

Minor code refactor - #251

Merged
viktorbeck98 merged 5 commits into
mainfrom
imp/core_components
Aug 10, 2026
Merged

Minor code refactor#251
viktorbeck98 merged 5 commits into
mainfrom
imp/core_components

Conversation

@ipmach

@ipmach ipmach commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Task

Minor changes to improve the code overall structure.

  • Improve persistency file separation from Core components.
  • Add prefix in the ID generator to allow unique IDs for different components.

Description

  • Now the IDs are not simple a number but the name of the component and the number.
  • Persistency interfaces now in the same file for code clean

     Core Component / Core Detector ------>  |(persistence module) ----> interface -----> Rest stuff |

  • This Pull-Request goes to the development branch.
  • I have successfully run prek locally.
  • I have added tests to cover my changes.
  • I have linked the issue-id to the task-description.
  • I have performed a self-review of my own code.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Comment thread src/detectmatelibrary/utils/persistency/component_interfaces.py Outdated
Comment thread src/detectmatelibrary/utils/persistency/component_interfaces.py Outdated
Base automatically changed from development to main August 10, 2026 11:25
@viktorbeck98
viktorbeck98 merged commit 1726f2e into main Aug 10, 2026
5 checks passed
@viktorbeck98
viktorbeck98 deleted the imp/core_components branch August 10, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants