feat: introduces optimized debug option - #150
Merged
Merged
Conversation
EnriqueParodi
requested changes
Aug 26, 2026
EnriqueParodi
left a comment
Collaborator
There was a problem hiding this comment.
The comment says "Override options" but the code appends. gcc and clang take the last optimisation flag, but nothing is overridden and -fno-omit-frame-pointer is passed twice.
Choosing the flags once before the list avoids both:
# -Og with compressed debug info builds smaller and runs faster than -O0, at the
# cost of some variables being optimised away.
if(SEN_OPTIMIZED_DEBUG)
set(debug_options_ -Og -gz)
else()
set(debug_options_ -O0 -g)
endif()
set(common_clang_gcc_options_
...
"$<$<CONFIG:Debug>:${debug_options_};-fno-omit-frame-pointer>"
"$<$<CONFIG:Release>:-O3>"
)
and the if(SEN_USER_SIZE_OPTIMIZED_DEBUG) block below goes away.
The option name would be more aligned with the others by using SEN_OPTIMIZED_DEBUG. The conan option would become with_optimized_debug to match.
Thanks!
Collaborator
Author
|
Good morning @EnriqueParodi, thanks for the review. I aligned the naming of the CMake option and factored out how the compiler flags are set. |
EnriqueParodi
previously approved these changes
Aug 27, 2026
EnriqueParodi
dismissed
their stale review
August 27, 2026 10:33
The merge-base changed after approval.
EnriqueParodi
force-pushed
the
SEN-1746-test-dead-reckoner-quaternion-vec3-implementation
branch
from
August 27, 2026 10:33
9afa3af to
53ebb21
Compare
EnriqueParodi
force-pushed
the
SEN-1680-optimize-sen-debug-experience
branch
from
August 27, 2026 10:33
046df95 to
1bdfbbf
Compare
EnriqueParodi
marked this pull request as draft
August 27, 2026 14:29
EnriqueParodi
marked this pull request as ready for review
August 27, 2026 14:29
EnriqueParodi
marked this pull request as draft
August 27, 2026 15:15
EnriqueParodi
marked this pull request as ready for review
August 27, 2026 15:15
EnriqueParodi
force-pushed
the
SEN-1746-test-dead-reckoner-quaternion-vec3-implementation
branch
from
August 27, 2026 18:04
53ebb21 to
ea352de
Compare
EnriqueParodi
force-pushed
the
SEN-1680-optimize-sen-debug-experience
branch
from
August 27, 2026 18:04
1bdfbbf to
db24cc7
Compare
EnriqueParodi
force-pushed
the
SEN-1746-test-dead-reckoner-quaternion-vec3-implementation
branch
from
August 27, 2026 18:25
ea352de to
d5bb17d
Compare
EnriqueParodi
force-pushed
the
SEN-1680-optimize-sen-debug-experience
branch
from
August 27, 2026 18:25
db24cc7 to
ba16eb9
Compare
luisgutierrezpereda
previously approved these changes
Sep 1, 2026
lolito93
force-pushed
the
SEN-1680-optimize-sen-debug-experience
branch
from
September 1, 2026 11:07
ba16eb9 to
add4734
Compare
lolito93
changed the base branch from
SEN-1746-test-dead-reckoner-quaternion-vec3-implementation
to
main
September 1, 2026 11:29
lolito93
dismissed
luisgutierrezpereda’s stale review
September 1, 2026 11:29
The base branch was changed.
Collaborator
Author
|
Can be re-approved and merged. |
luisgutierrezpereda
approved these changes
Sep 1, 2026
EnriqueParodi
enabled auto-merge
September 2, 2026 07:00
EnriqueParodi
self-requested a review
September 2, 2026 07:00
EnriqueParodi
approved these changes
Sep 2, 2026
EnriqueParodi
force-pushed
the
SEN-1680-optimize-sen-debug-experience
branch
from
September 10, 2026 08:55
8831db8 to
6b48d69
Compare
With the `SEN_USER_SIZE_OPTIMIZED_DEBUG` users can now control whether they want a smaller and better optimized debug build that is fast and has reliable debug information. Resolves SEN-1680
The option becomes `SEN_OPTIMIZED_DEBUG`, dropping the `USER_SIZE` part of the name it was introduced with, and the flags it turns on are set in one place in sen_misc_utils.cmake rather than being spelled out where they are used. Resolves SEN-1680
EnriqueParodi
force-pushed
the
SEN-1680-optimize-sen-debug-experience
branch
from
September 10, 2026 09:45
6b48d69 to
beb44e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the
SEN_USER_SIZE_OPTIMIZED_DEBUGusers can now control whether they want a smaller and better optimized debug build that is fast and has reliable debug information.Resolves SEN-1680